244209 - Offline Settings > KB value not be stored for 'Compact folders if it will save over ....'

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Thunderbird 0.6+ (20040520)

Bug in Offline settings. The KB value for 'Compact folders if it will save over
... KB' is not stored. This Bug is not fixed for some month now.

Reproducible: Always
Steps to Reproduce:
1. Go into Offline settings
2. Activate the option 'Disk Space' > 'Compact folder when it will save over ...
KB' and enter an other value - e.g. 333 KB (default is 100 KB).
3. Click 'OK' to confirm the settings

Actual Results:  
When you've a look into the prefs.js, there is evertimes the default value (100
KB) stored. NOT your entered value (e.g. 333 KB).
When you're reopening the offline settings, you'll see the 100 KB value again -
everytimes.

Expected Results:  
Your entered value should be saved (e.g. 333 KB).

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: patched version of pref-offline.xul

In function savePrefs() the following has to be changed:

Original:
else if (eltType == "textbox" && element.preftype == "int")
pref.setIntPref(element.getAttribute("prefstring"),
parseInt(element.getAttribute("value")) );

Fixed:
else if (eltType == "textbox")
pref.setIntPref(element.getAttribute("prefstring"), parseInt(element.value));

Don't know why, but the original code does not save the KB value.

Comment 2

[Scott MacGregor]

Attachment: possible fix

diepause, does this patch fix it for you?

Thanks a lot for tracking this down!

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Hi Scott,

your proposed patch does NOT work for me. The only working solution is to not
check the preftype. I've been testing this in combination with Thunderbird 0.5,
0.5+, 0.6, 0.6+ (20040523).

BTW: there is NO JavaScript error in the JS-console.

As long as we've only this one textbox in pref-offline.xul, we can successfully
use my proposed patch.

BTW: the attachment 148971 [details] is based on the offline extension with the (old)
bigger panel.

Comment 4

[Scott MacGregor]

ok

fixed on teh trunk and aviary

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

Today I'be been testing Thunderbird branch 0.7 build 2004-05-31. The bug is NOT
fixed in this build?!

Code out of the offline extension in this build:
else if (eltType == "textbox")
  pref.setIntPref(element.getAttribute("prefstring"),
  parseInt(element.getAttribute("value")) );

The only working code for me:
else if (eltType == "textbox")
  pref.setIntPref(element.getAttribute("prefstring"), 
  parseInt(element.value));

Comment 6

[Scott MacGregor]

re-closing I just made the necessary adjustment again. Not sure what happened
last time.

Comment 7

[Mike Cowperthwaite]

*** Bug 239027 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Cowperthwaite]

*** Bug 243612 has been marked as a duplicate of this bug. ***