244457 - Don't show vCards as external attachments

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

libmime renders the vcard internally and clicking on the vcard takes you to our
address book UI.

Don't clutter up the UI by marking the message as having an attachment and
showing it as an external attachment.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

Attachment: follow up fix

The original patch caused a regression (thanks diepause). If attachments were
NOT being viewed as inline then the vCard was not showing up as an external
attachment.

There is still one subtle side effect which I don't think we really care about.
I was hoping to not mark the message as having attachments if the only
attachment was a vCard. This will work as I intended for the inline case but
non inline will still show up as having an attachment. That's probably fine and
not worth fixing.

Comment 3

[Scott MacGregor]

the 2nd patch is now in the trunk and the aviary 1.0 branch

Comment 4

[Scott MacGregor]

Attachment: follow up fix to address View Message Body as plain text or simple HTML

this follow up fix makes it so we show the vcard information as an external
attachment if you are viewing the message body as simple HTML or plain text.

Comment 5

[timeless]

Comment on attachment 149864 [details] [diff] [review]
follow up fix to address View Message Body as plain text or simple HTML

please fix the comment.