244489 - Customize Sidebar dialog clipped in Modern

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Daniel Veditz [:dveditz]]

The Customize Sidebar dialog has the up/down and cancel buttons clipped on the
right side in the Modern skin.

Because the size of this dialog is persistant you need to clear old values out
of localstore.rdf before testing this. Real users will see this clipped dialog
if they switch to the Modern theme before opening the customize dialog for the
very first time.

Comment 1

[Daniel Veditz [:dveditz]]

Attachment: remove hardcoded width

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

Removes hardcoded width so sizeToContent can do its thing. Originally added to
fix bug 37724. Leaving height or else dialog squashes down as in the testcase
to bug 37836 (which must've been band-aided, the underlying cause is still
there).

Comment 3

[[e-mail]]

Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

As to bug 37836, instead of trees that dialog now uses listboxes which are
defined in xul.css to have a default size of 200px. Or alternatively instead of
specifying an overall height you could have added rows="20" (say) to the trees.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

sr=sspitzer

Comment 5

[chris hofmann]

Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

a=chofmann for 1.7

Comment 6

[Daniel Veditz [:dveditz]]

checked into trunk and branch

Comment 7

[Tracy Walker [:tracy]]

verified