244531 - allow a hidden pref ("imageblocker.enabled") to hide image blocking context menu UI

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

allow a hidden pref ("imageblocker.enabled") to hide image blocking context menu UI.

on request of a browser vendor / distributor.

I'll attach a patch for review.

aiming for Mozilla 1.7, as that's the long lived branch that people will be
shipping off of.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

I didn't define a default for this pref, but I could. 

I'll request a r= from neil and see what he thinks.

Comment 3

[(not reading, please use [e-mail] instead)]

mike, could you review?

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 149217 [details] [diff] [review]
patch

so we're not touching the Tools->Image Manager UI options or the pref panel?  I
can live with that

I don't think we need to define a default value in this case, but if we were
going to hide the other UI elements I'd want one

Comment 5

[(not reading, please use [e-mail] instead)]

> so we're not touching the Tools->Image Manager UI options or the pref panel?  I
> can live with that

right, this pref only affects the context menu item.  and for Mozilla 1.7, this
pref would not be set, so there would be no change.  it is for other browser
distrbutors.

> I don't think we need to define a default value in this case, but if we were
> going to hide the other UI elements I'd want one

ok, thanks for the review.

Comment 6

[(not reading, please use [e-mail] instead)]

for some history, see http://bugzilla.mozilla.org/show_bug.cgi?id=208882

thanks to dveditz for pointing that out.

Comment 7

[(not reading, please use [e-mail] instead)]

to summarize the relation ship to
http://bugzilla.mozilla.org/show_bug.cgi?id=208882, this pref does less than it
used too.

now, we just use this pref to hide the context menu item.  

but as mike points out, the rest of the feature is there.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 149217 [details] [diff] [review]
patch

sr=dveditz

Comment 9

[(not reading, please use [e-mail] instead)]

note, this fix will be on the 1.7 branch only.

I won't be adding this patch to the trunk.  

as per http://bugzilla.mozilla.org/show_bug.cgi?id=208882, that pref is dead.

but 1.7 is the successor to 1.4, and this was in 1.4.

Comment 10

[chris hofmann]

Comment on attachment 149217 [details] [diff] [review]
patch

a=chofmann for 1.7

Comment 11

[(not reading, please use [e-mail] instead)]

fix landed on the 1.7 branch only.

Comment 12

[tyl2]

If this patch only affects the context menu, shouldn't the pref name say 
dat? As of now it sounds like it could disable the whole blocking 
mechanism.

Comment 13

[(not reading, please use [e-mail] instead)]

it is misleand, but that's the pref that 1.4 used.  (1.4 did more disabling than
1.7 will do)

It's staying on the 1.7 branch, to encourage people who used 1.4 to move to 1.7.

Comment 14

[(not reading, please use [e-mail] instead)]

s/misleand/misleading

Comment 15

[Michael Lefevre]

seems this was also landed on aviary

Comment 16

[Mike Connor [:mconnor]]

if it did, it would have no effect whatsoever.

Comment 17

[Tracy Walker [:tracy]]

verified