244541 - Check in recent Help fixes to AVIARY_1_0_20040515_BRANCH

Status: VERIFIED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Peter van der Woude [:Peter6]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040516 Firefox/0.8.0+ (JTw)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040524 Firefox/0.8.0+  zip

The first time Firefox is started (after installation) the help window is empty.
It only contains an XML errormessagein the lower part of the window.
When it's opened again, the help content is there, and the XML error remains.

XML error:

label="&goBackCmd.label;"
-------^  
  (arrow under the &)

Reproducible: Always
Steps to Reproduce:

Actual Results:  
it takes 2 times to see the helpcontent

Expected Results:  
It should show the first time
the errormessage shouldn't be there

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I can confirm this bug on win98 using the official ZIPped AVIARY build.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040524 Firefox/0.8.0+

Comment 2

[Jeff Walden (gone starting June 8)]

Well, I was simply going to send you an email, R.J., but as a bug's been opened
I see no reason not to use it.

The problem is that recent Fx Help checkins have only been to the trunk.  See
<http://snurl.com/fxhelp_fixes_720h> for checkins over the last month or so; all
checkins after 20040511 have been trunk-only.  To fix this particular bug as
originally written only one of the checkins really needs to be made, but it
probably makes sense to morph the bug into one that covers all the checkins. 
While you're at it, you can probably add in the accesskey fix for the context
menu from the recent Mozdev bug - it's only one missing character.

Comment 3

[Steffen Wilberg]

We mustn't ship 0.9 with this.

Comment 4

[Mike Connor [:mconnor]]

yes yes, please get this checked in ASAP

Comment 5

[Jeff Walden (gone starting June 8)]

Hmm, I got an email from R.J. about his schedule right now.  Excerpt below:

"I'm going to be busy within the next 2 weeks for finals at school...If you have
any questions or concerns, feel free to email me but please be aware that I
might not get back to your email within that day."

So in conclusion: it sounds as if he'll /probably/ have time to do this, but not
necessarily ASAP.  If he doesn't it'll need to wait (definitely not so good).

Comment 6

[Mike Connor [:mconnor]]

I guess I'll have to do this myself then, we're not going to ship without these
fixes.

should get landed by the end of the weekend

Comment 7

[R.J. Keller]

mconnor: I can get these landed tomorrow. I managed to cook up a couple of hours
to wade through bugs tomorrow. Sorry for being so busy! I'm going to wade
through my bugmail tonight and hopefully get this landed tomorrow.

If you can get this done sooner or already have work done on it, feel free to
reassign back to yourself.

Comment 8

[R.J. Keller]

OK, Help is landed! This also includes the fix for right-click menu problem
which isn't yet on the trunk (it was a minor typo, so I thought that I would
include it).

Comment 9

[Jeff Walden (gone starting June 8)]

(In reply to comment #8)
> OK, Help is landed! This also includes the fix for right-click menu problem
> which isn't yet on the trunk (it was a minor typo, so I thought that I would
> include it).

If your menu problem is the right-click TEXTZOOMENLARGEBTN.ACCESSKEY; problem,
it doesn't seem to have been fixed, trunk or branch.  See latest revs on:

http://bonsai.mozilla.org/cvsgraph.cgi?file=mozilla/toolkit/components/help/content/helpContextOverlay.xul

As a typo it really wouldn't require a review according to
<http://mozilla.org/projects/firefox/review.html>.

Comment 10

[Steffen Wilberg]

Indeed, in toolkit/components/help/content/helpContextOverlay.xul 
      		accesskey="textZoomEnlargeBtn.accesskey;"
needs to replaced by
      		accesskey="&textZoomEnlargeBtn.accesskey;"
(note the '&').

Comment 11

[Steffen Wilberg]

Reopening to get this back on the radar. We don't need a separate bug to fix
that typo, do we?

Comment 12

[Mike Connor [:mconnor]]

no

fixed branch and trunk

Comment 13

[R.J. Keller]

You're one step ahead of me on this one mconnor! I was just about to fix it!
Thanks for getting this one for me!

VERIFIED. I think Jeff checked this in on the firefox help trunk, so everything
looks good!