244651 - nsTextFrame::Reflow does too much work

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Brian Ryner (not reading)]

TextStyle is a stack-based object that is used to avoid recomputing
frequently-used style data for text frames during a given call to Reflow(),
Paint(), etc.  However, TextStyle doesn't discriminate between the Reflow and
Paint cases, and as a result it spends time getting colors (from the style
context and the LookAndFeel) when they aren't to be used for anything.

I have a patch which makes a TextPaintStyle class (a subclass of TextStyle) that
contains the extra color data.  Local testing shows almost a 2% improvement in
Tp from this (redwood tinderbox showed only about 1%; the average will probably
be somewhere in between).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

This also removes some overzealous initialization and nulling out of members in
the TextStyle object.  Hopefully there's no subtle reason I missed that those
pointers were nulled out in the dtor.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 149282 [details] [diff] [review]
patch

One more thing... I simply removed mVisibility; it's not used for anything.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 149282 [details] [diff] [review]
patch

Looks reasonable.  r+sr=bzbarsky

Comment 4

[Brian Ryner (not reading)]

checked in.

Comment 5

[rbs]

*** Bug 77939 has been marked as a duplicate of this bug. ***