244655 - Uninstalling an extensions renders firefox useless

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Samir L. Boulema]

Uninstalling an extensions renders firefox useless and disfunctional. Only way
to cure is a new install and a new profile.

Steps to reproduce:
- Start Firefox
- Install Theme
- Close Firefox
- Uninstall Theme
- Close Firefox
- Start a crippled version of Firefox

Noticing this on: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040524
Firefox/0.8.0+

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040525
Firefox/0.8.0+
I confirm

Comment 2

[Peter van der Woude [:Peter6]]

some so called FF0.9 proof extensions do that, others don't.
We need a benchmark extension to properly test.

Comment 3

[Oakwine]

(In reply to comment #2)
> some so called FF0.9 proof extensions do that, others don't.
> We need a benchmark extension to properly test.

I encountered this bug attempting to uninstall Piro's Rewind/Fastforward Buttons
(0523 version):
http://white.sakura.ne.jp/~piro/xul/_rewindforward.html.en

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040525
Firefox/0.8.0+

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

It seems renumbering prevents the item from being removed from the container.
This smells like an RDF bug but we don't really need to renumber so I'll paper
over this for now. Also use a dirty flag to prevent writing do a ds that has no
changes made to it - useful when the user has no write permissions to the
install dir.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed branch and trunk.