244677 - Window-Eyes saying "loading page" and "load done" for non-visible documents

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

If you load a tab in the background, Window-Eyes should not try to grab the MSAA
tree for it. It should also ignore the spurious about:blank load when Mozilla is
first launched.

Steps:
1. Run Window-Eyes
2. Run Mozilla, hear "loading page" "load done" twice
3. When focused on a link, hit Shift+insert to load link in backgroud - hear
"loading page" "load done" and notice that you can't navigate the current page
anymore.

What should happen:
For step 2 - Should only say "loading page" "load done" once
For step 3 - Shouldn't load a page unless it's visible on the screen

Comment 1

[Aaron Leventhal]

Attachment: 1) Implement STATE_INVISIBLE for docs. 2) Don't fire state change for doc load finished unless doc is visible, 3) Use delay before attempting to fire doc load finished event

Comment 2

[Kyle Yuan]

Comment on attachment 149299 [details] [diff] [review]
1) Implement STATE_INVISIBLE for docs. 2) Don't fire state change for  doc load finished unless doc is visible, 3) Use delay before attempting to fire doc load finished event

r=kyle, just one question: (no new patch needed)

>+  if (shell) {
>+    shell->GetDocument(getter_AddRefs(mDocument));

why do you re-get the document here? mDocument is already set in the
constructor.

Comment 3

[Aaron Leventhal]

Right, Kyle, thanks. I'll remove the unnecessary line.

Comment 4

[Aaron Leventhal]

Checking in nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.38; previous revision: 1.37
done

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381