244688 - In <FilterEditor.js>, "Warning: assignment to undeclared variable gChangeJunkScoreCheckbox"

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040514] (<-- 1.7rc2 !)
(W98SE)

{{
Warning: assignment to undeclared variable gChangeJunkScoreCheckbox
Source File: chrome://messenger/content/FilterEditor.js
Line: 280
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <FilterEditor.js>

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 149306 [details] [diff] [review]
(Av1) <FilterEditor.js>

Could you (super-)review/check in this patch ? Thanks.

Comment 3

[Henry Jia]

Comment on attachment 149306 [details] [diff] [review]
(Av1) <FilterEditor.js>

r/sr=Henry

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 149306 [details] [diff] [review]
(Av1) <FilterEditor.js>


'approval1.7=?':
Trivial U.I. 'undeclared variable' declaration, no risk.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 149306 [details] [diff] [review]
(Av1) <FilterEditor.js>

I don't see the end user gain here.

this should be trunk only.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <FilterEditor.js> [Checked in: Comment 8]

Av1 was correct;
Then, I discovered lately that I could go for less rather than more :->

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 150942 [details] [diff] [review]
(Av2) <FilterEditor.js>
[Checked in: Comment 8]


Sorry to ask again.

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Mike Cowperthwaite]

(Why is the checked-in patch now obsoleted?)

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)
> (Why is the checked-in patch now obsoleted?)

(It's my way of keeping track: obsoleted == done with it.)