244753 - Support STATE_READONLY / STATE_EDITABLE for editors

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Any HTML window can turn into an editor window at any time.

The nsDocAccessible/ROLE_EDITOR object should support STATE_READONLY (or
ATK_STATE_EDITABLE under Linux).

State change events should also be fired.

Comment 1

[Aaron Leventhal]

Attachment: Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

Comment 2

[Kyle Yuan]

Comment on attachment 149346 [details] [diff] [review]
Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

over to Louie.

Comment 3

[Louie Zhao]

Aron, can you explain more detailed on how to turn a HTML window into an editor
window in mozilla (do you mean composing)? Although the patch looks good to me,
how can I find a way to trigger a HTML window to change state?

Comment 4

[Aaron Leventhal]

Comment on attachment 149346 [details] [diff] [review]
Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

Kyle, can you r= this after all? Louie says he's gone for the next week.

Here's a demo of setting design mode for the document. It could happen later in
the life of the document.
http://www.mozilla.org/editor/midasdemo/

Comment 5

[Aaron Leventhal]

More specifically

<iframe id="edit" width="100%" height="200px"></iframe>

JS to turn on editing for iframe:
 document.getElementById('edit').contentWindow.document.designMode = "on";

Comment 6

[Kyle Yuan]

Comment on attachment 149346 [details] [diff] [review]
Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

looks good to me. r=kyle. BTW, Henry is also not in office in rest of this
week.

Comment 7

[Aaron Leventhal]

Comment on attachment 149346 [details] [diff] [review]
Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

I just realized I'll have to update the comment as well (so that it doesn't
refer to STATE_MARQUEED anymore).

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 149346 [details] [diff] [review]
Support readonly/editable. Sun - please let me know if ATK parts are wrong or unnecessary.

sr=jst

Comment 9

[Aaron Leventhal]

Checking in src/base/nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in src/atk/nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/atk/nsDocAccessibleWrap.cpp,v  <-- 
nsDocAccessibleWrap.cpp
new revision: 1.13; previous revision: 1.12
done

Comment 10

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381