244921 - tweak nsGenericHTMLElement for code size

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The DOM attribute mapping macros can be improved slightly by using slightly
better helpers. Patch coming up.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

0) Add helpers for every situation
1) ensure that all helpers return NS_OK when appropriate, so all macro methods
can do a tail call. This may help some compilers to tail-call optimizations.
2) pass only the minimum number of parameters to each helper
3) pass a const char* to GetAttrWithDefault to avoid NS_LITERAL usage.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix2

fix compiler error

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 149473 [details] [diff] [review]
fix2

Got any savings numbers (no sweat if you don't)?

r+sr=jst

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I was hoping to get some from Tinderbox :-)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This saved 3-4K of code. It also caused a slowdown on btek, although not on
other tinderboxes. I'm not sure what the deal is. I'll probably back this out.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backing it out didn't seem to fix btek. So I'm putting it back in.