244932 - horizontal line (hr) overlap (moz-float-edge) right float

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[octavian costache]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514

In the page http://olimpiada.info/bynet/index.php the horizontal line ovelapes a
table that is aligned to the right.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This needs a minimal testcase.

Comment 2

[Martijn Wargers (dead)]

Attachment: Simple testcase

It only happens with <hr size="1">
According to:
http://www.w3.org/TR/REC-html40/present/graphics.html#h-15.3
it sets the height of the rule, but in Mozilla it seems to set the
border-widths of the rule, the height of the rule stays 0px.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Interesting.  Looks like having only a top border and no side borders confuses
moz-float-edge.... (setting side borders on those overlapping hrs makes them
stop overlapping).

I swear I've seen a bug on that before, but I can't find it... :(

Comment 4

[Ng Ming Hong]

Bug 246179 is similar to this one:
http://bugzilla.mozilla.org/show_bug.cgi?id=246179

I think Mozilla added extra left margin to the horizontal rules... See how the
page is forced to scroll horizontally.

Comment 5

[Martijn Wargers (dead)]

This seems to have regressed.
The simple testcase works in: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/2004-01-15
Firebird/0.8.0+
But it doesn't work in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/2004-01-20
Firebird/0.8.0+

Backing out the patch for bug 52916 fixes the testcase for this bug.

Comment 6

[Martijn Wargers (dead)]

Attachment: I meant backint out this line of text

Comment 7

[Martijn Wargers (dead)]

Attachment: workaround patch for html.css

Or html.css could be changed, so the bug would become less visible.

Comment 8

[Martijn Wargers (dead)]

*** Bug 265463 has been marked as a duplicate of this bug. ***

Comment 9

[Mats Palmgren (inactive)]

*** Bug 273145 has been marked as a duplicate of this bug. ***

Comment 10

[Mats Palmgren (inactive)]

*** Bug 281693 has been marked as a duplicate of this bug. ***

Comment 11

[Mats Palmgren (inactive)]

(In reply to comment #7)
> Created an attachment (id=151614) [edit]
> workaround patch for html.css

Good idea, the problem with this patch is that it increases the box height
from 1px to 2px and that it changes the border-bottom-color to transparent
which makes the following bottom border invisible:
<hr size="1" style="border-bottom-width: 5px; border-bottom-style:solid">

Comment 12

[Mats Palmgren (inactive)]

Attachment: html.css patch, rev. 2

Something like this perhaps

Comment 13

[Mats Palmgren (inactive)]

I think it could be worth taking this as a wallpaper until moz-float-edge
sucks less.

Comment 14

[Boris Zbarsky [:bzbarsky]]

So why not set only what we want to set?  That is:

border-top-style: -moz-bg-solid
border-right: 1px solid transparent;
border-left: 1px solid transparent;

(if the border-left is needed) and not mess with border-bottom at all?

Comment 15

[Martijn Wargers (dead)]

Attachment: Like this?

Like this?
Indeed, border-left is not needed to fix the testcase. I haven't really tried
this on other testcases or url's.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Hmm... Except we do want to turn off the bottom border from the "hr" rule...
Maybe the right thing is:

border-top-style: -moz-bg-solid;
border-bottom-style: none;
border-right: 1px solid transparent;
border-left: 1px solid transparent;

(and I'd like to leave left and right symmetric, yes).

Note that that (as all proposed solutions to this bug) introduces an issue with
<hr width="100%">, though...

Comment 17

[Biju]

is bug#267353 same as this?

Comment 18

[Boris Zbarsky [:bzbarsky]]

No.

Comment 19

[j.j.]

Testcase wfm.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061214 Minefield/3.0a1

Comment 20

[Boris Zbarsky [:bzbarsky]]

Works in 2006-12-08-01 but not in 2006-12-07-01.  Fixed by reflow branch landing.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Attachment: Reftests

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 257614 [details] [diff] [review]
Reftests

Checked in after testing in pre- and post-reflow-branch builds.