24495 - Anonymous inline for line box minimum height not baseline-aligned {ll}

Status: VERIFIED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Hixie (not reading bugmail)]

The anonymous inline element which is assumed to exist on each line box and
which implements the minimum line-box height set by the parent block's
line-height property is currently being centered about other inline elements
on the line.

It should be baseline aligned, and applied before any other inline elements
are layed out.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

IMO, marking this "css1" is deceptive, since it's really just a bad way of
implementing CSS1 rather than nonconformance...

Comment 2

[Hixie (not reading bugmail)]

The "css1" keyword doesn't mean non-conformance, it just means that this bug
is something to do with behaviour specified by the CSS1 spec.

Comment 3

[Hixie (not reading bugmail)]

This seems to be ok. Marking WORKSFORME and reassigning to David.

David, since you were the one who told me this was broken, I'll let you write
a test case to show the brokeness here. My attempt seems to demonstrate that
we work as you are advocating. If you agree that this is actually ok, then 
please verify worksforme.

My test case (requires Ahem):
   http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/lineheight6.html

Comment 4

[Hixie (not reading bugmail)]

Also setting milestone to M16 and reducing priority.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm beginning to think the code I saw doesn't do anything anymore, and can be
removed...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified worksforme.  (It should really be tested with multiple lines,
though...)

Comment 7

[buster]

I think I have a fix for this, but I am unable to load the ahem font to test on 
the given URL.  I downloaded it using "Save As" with the link on the test page 
to my WinNT box and WinNT thinks it's corrupt and refused to recognize it as a 
font file.  Could you put it out somewhere for standard ftp binary download?  
Thanks.

Comment 8

[Hixie (not reading bugmail)]

buster: What does your fix do? As far as David and I can tell, this bug is not
a bug! It works fine. Are you removing the redundant code David mentioned in his
2000-01-24 16:47 comment?

Anyway, I've put another copy of the Ahem font's TTF file at:
   http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/AHEM____.TTF
If that still causes problems, I'll mail it to you (<30K). Sorry, I don't have
access to an FTP site.

David: There is now a multiple line version of the test at the URI. It seems to
work fine in Mozilla.

Comment 9

[Hixie (not reading bugmail)]

Ok, per buster's comments on bug 24186, disregard buster's comments above, on 
this bug. 

David, since this clearly works, do you want to have a look at whether the code
you saw before is indeed redundant, or shall we forget this bug was ever filed?

petersen: I'm taking over QA contact for this bug.

Comment 10

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/727ffd6fe970
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24495 fix and re-enable settingsPrivacyItemsTest UI test. (https://github.com/mozilla-mobile/fenix/pull/24705)