244951 - shrink to fit, background on, trap or hang during printing

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[resnais]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6) Gecko/20040526

Short info
----------
Test Case : n/a
URL       : www.go.com
            271.zip


Environment
-----------
IWB Build ID         : 2.0.3 Gecko/20040428

Device name          : LASERJET.HP LaserJet 8000
Printer driver ver   : 30.817
Printer driver date  : 04.30.2004
Printer driver path  : PCL6
Printer name         : HP LaserJet 8000

Other devices (OK)   : none
                       
Other devices (FAIL) : PSCRIPT.HP Color LaserJet 5500
                       LASERJET.HP C LaserJet 5500 (PCL6)
                       LASERJET.HP LaserJet 8000 (PCL5, PCL5 + HP-GL/2)
                       PSCRIPT.HP LaserJet 9000 PS
                       OMNI.HP DeskJet 995c

OS                   : acp2  - fail
                       mcp2  - fail
                       win32 - OK

OS/2 FixPak          : xr_c004
OS/2 Language        : us_EN
OS/2 Video driver    : SciTech SNAP Graphics/se, GM17

Reproducible: Always
Steps to Reproduce:
1. Install IBM Web Browser.
2. Install printer driver, create Print Object.
3. Open Print Preview.
3. Enable Print Beckgroung (colors & image) in Page Setup.
4. Set Scale to Shrink to Fit.
5. Close Print Preview.
4. Print web page.
Actual Results:  
There is a trap:

05-13-2004  14:29:34  SYS3175  PID 0052  TID 0001  Slot 0047
H:\OS2WEB\OS2WEB.EXE
c0000005
1fde4d46
P1=00000001  P2=07000b59  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=07000b59  EBX=0000dbdb  ECX=000000db  EDX=00000000
ESI=0000000d  EDI=00000374  
DS=0053  DSACC=f0f3  DSLIM=ffffffff  
ES=0053  ESACC=f0f3  ESLIM=ffffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:1fde4d46  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:0013dc40  SSACC=f0f3  SSLIM=ffffffff
EBP=00a54c00  FLG=00212216

PMGPI.DLL 0001:00004d46

when printing www.go.com with enabled background printing and Scaling Shrink to
Fit. If scaling is set to 100% (or any other) then works fine.

The same problem for previous build (2.0.3 Gecko/20040310)

Trap is only for LASERJET driver PCL6 path. For other drivers and Laserjet PCL5
there is a hang.
Hang is recreatable on local copy of the web page.

Expected Results:  
No trap\hang, web page is printed.

Comment 1

[resnais]

The problem was that we were getting a bad DestWidth/DestHeight

Here is the fix:

Index: nsImageOS2.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/os2/nsImageOS2.cpp,v
retrieving revision 1.48
diff -u -r1.48 nsImageOS2.cpp
--- nsImageOS2.cpp       20 Apr 2004 02:31:07 -0000       1.48
+++ nsImageOS2.cpp       25 May 2004 18:21:09 -0000
@@ -682,6 +682,7 @@
    PRInt32 DestHeight = mInfo->cy * scale;
 
    // Copy bitmap horizontally, doubling each time
+   if (DestWidth && DestHeight) {
    while (DestWidth < aTileWidth)
    {
       POINTL aptlCopy [3] = { {DestWidth, 0},                     // TLL - in
@@ -702,6 +703,7 @@
       GFX (::GpiBitBlt (hpsTile, hpsTile, 3, aptlCopy, ROP_SRCCOPY, 0L),
GPI_ERROR);
       DestHeight *= 2;
    }
+   }
 }
 
 /** ---------------------------------------------------

Comment 2

[resnais]

Attachment: Local copy of the web page

File 271.zip contains a local copy of the web page.

Comment 3

[Boris Zbarsky [:bzbarsky]]

resnais, could you attach the patch to this bug and request review on it
(probably from mkaply)?

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Patch

This was actually my patch originally. Getting Javier ro review.

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in.