245009 - Kill C++ urlbar history

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[[e-mail]]

The C++ urlbar history code is almost superfluous. Most of it was reimplemented
in JS in sessionHistoryUI.js, so once pref-history.xul has been converted to
pure JS/RDF the C++ version can me removed.

CCing people who can drum up volunteers.

Comment 1

[[e-mail]]

Attachment: Part 1 - FE

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Part 2 - BE

Comment 3

[Axel Hecht]

Comment on attachment 149647 [details] [diff] [review]
Part 1 - FE

not really my bucket. But anyway, r=me

Comment 4

[Benjamin Smedberg]

Comment on attachment 149652 [details] [diff] [review]
Part 2 - BE

r=me for what appears to be a mindless build-config change

Comment 5

[Alec Flett]

Comment on attachment 149647 [details] [diff] [review]
Part 1 - FE

wow, thats simple. Scary simple. 

I really wish we would just hook this up to global history though.. we already
know which URLs should go into URLBar History, because they have the "typed"
attribute set.

sr=alecf

Comment 6

[Alec Flett]

Comment on attachment 149652 [details] [diff] [review]
Part 2 - BE

sr=alecf

Comment 7

[[e-mail]]

(In reply to comment #5)
>I really wish we would just hook this up to global history though.. we already
>know which URLs should go into URLBar History, because they have the "typed"
>attribute set.
Although URLBar history does expect them to stay in order...

Comment 8

[Alec Flett]

sure, but we could mimic that in history by looking for all typed urls, sorted
by date-most-recently-visited and we'd get more or less the same list in the
same order.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

c++ part checked in, marking fixed

Comment 10

[Hiro]

The next file is referred to by the project file of Camino. 
  mozilla/camino/Camino.xcode/project.pbxproj
  line: 11212 - 11219
  xpfe/components/urlbarhistory/public/_xpidlgen/urlbarhistory.xpt

For this reason, an error occurs in build of Camino.
Please remove this entry.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #10)
> The next file is referred to by the project file of Camino. 
>   mozilla/camino/Camino.xcode/project.pbxproj
>   line: 11212 - 11219
>   xpfe/components/urlbarhistory/public/_xpidlgen/urlbarhistory.xpt
> 
> For this reason, an error occurs in build of Camino.
> Please remove this entry.

I'm not familiar with pbxproj files... it seems a bit nontrivial to remove this
entry... can someone who knows this file do this?

(strangely, the camino tinderboxes are all green...)

Comment 12

[Hiro]

>(strangely, the camino tinderboxes are all green...)
I think that it is because it is not building in the really clean state.

The following is an error log.

PBXCp build/Camino.app/Contents/MacOS/components/urlbarhistory.xpt
/Users/sek/Documents/mozilla-current/camino/mozilla/xpfe/components/urlbarhistory/public/_xpidlgen/urlbarhistory.xpt
    cd /Users/sek/Documents/mozilla-current/camino/mozilla/camino
    /Developer/Tools/pbxcp -exclude .DS_Store -exclude CVS -strip-debug-symbols
-resolve-src-symlinks
/Users/sek/Documents/mozilla-current/camino/mozilla/xpfe/components/urlbarhistory/public/_xpidlgen/urlbarhistory.xpt
/Users/sek/Documents/mozilla-current/camino/mozilla/camino/build/Camino.app/Contents/MacOS/components
/Users/sek/Documents/mozilla-current/camino/mozilla/xpfe/components/urlbarhistory/public/_xpidlgen:
No such file or directory
** BUILD FAILED **
make[2]: *** [libs] Error 1
make[2]: Leaving directory
`/Users/sek/Documents/mozilla-current/camino/mozilla/camino'

Comment 13

[Hiro]

Attachment: quick fix patch

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #13)
> Created an attachment (id=150075)
> quick fix patch
> 

Thanks - I checked this patch in
Checking in camino/Camino.xcode/project.pbxproj;
/cvsroot/mozilla/camino/Camino.xcode/project.pbxproj,v  <--  project.pbxproj
new revision: 1.17; previous revision: 1.16
done