245035 - cleanup help-toc.rdf

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Michael Opitz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040527
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040527

While working on Bug 203458 i noticed some things in help-toc.rdf


Reproducible: Always
Steps to Reproduce:

Comment 1

[Michael Opitz]

Attachment: first part

this is the first part.
I also notice that white-space is not always the same

Comment 2

[R.J. Keller]

Comment on attachment 149580 [details] [diff] [review]
first part

> -        <rdf:li><rdf:Description ID="shortcuts" nc:name="Mozilla Keyboard Shortcuts" nc:link="chrome://help/locale/shortcuts.xhtml"/> </rdf:li>
> +        <rdf:li> <rdf:Description ID="shortcuts" nc:name="Mozilla Keyboard Shortcuts" nc:link="chrome://help/locale/shortcuts.xhtml"/> </rdf:li>
> +        <rdf:li> <rdf:Description ID="tools" nc:name="Tools and Development" nc:link="chrome://help/locale/developer_tools.xhtml"/> </rdf:li>

Why are you making this change? It was correct the way it was.

Thanks for the patch! You definetely caught some problems in the TOC RDF!

Comment 3

[R.J. Keller]

--> michael.opitz

Comment 4

[Michael Opitz]

(In reply to comment #2)
> Why are you making this change? It was correct the way it was.

Since all root-Elements where in the section at the beginning and only the
tools-entry had was in a seperat root-section i thought they should be together.
But when each entry should be at the beginning of the spezific section i can
change this

Comment 5

[R.J. Keller]

Comment on attachment 149580 [details] [diff] [review]
first part

> Since all root-Elements where in the section at the beginning and only the
> tools-entry had was in a seperat root-section i thought they should be together.
> But when each entry should be at the beginning of the spezific section i can
> change this

oh sorry! so some reason I thought you were adding it to the Keyboard Shrotcuts
item. I have been ill lately, so you'll have to excuse me.

Thanks for the patch! r=[e-mail].

Comment 6

[Michael Opitz]

Attachment: Updated patch

Since the checkin for Bug 236942 the old patch doesn't apply anymore.

This patch will do.
no change from old patch.

Comment 7

[Michael Opitz]

Attachment: Updated Patch

Another time the patch doesn't apply.
This time i also fixed a link from the last checkin to help-toc.rdf

Comment 8

[Michael Opitz]

Comment on attachment 152254 [details] [diff] [review]
Updated Patch

rlk can you give r+ and chack this in pls.

Comment 9

[R.J. Keller]

Fix checked in. Thanks michael!

Comment 10

[R.J. Keller]

Checked in a whitespace change to give you credit for the patch. Sorry for not
doing it before.