245148 - [null].toSource() == [].toSource() : null in array is blank

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Thomas Blatter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Array.toSource() represents null as 'blank' (instead of expected 'null'). This
in all versions of Firefox / Mozilla i had at hand.

Reproducible: Always
Steps to Reproduce:
1. lauch javascript console
2. type [null].toSource() in command line


Actual Results:  
prints: []

Expected Results:  
should print: [null]

Comment 1

[Brendan Eich [:brendan]]

Patch in a trice.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed fix

Easy, got rid of a useless assignment too.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk.  Going for 1.7 approval.

/be

Comment 4

[Brendan Eich [:brendan]]

Fixed on the 1.7 branch too.

/be

Comment 5

[Brendan Eich [:brendan]]

Fixed for 1.7 too.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: js1_5/Regress/regress-245148.js

Thomas, with your permission this will be included in the javascript test
suite.

Comment 7

[Bob Clary [:bc] (inactive)]

No reply, but since this case is so trivial, I have checked in
js/tests/js1_5/Regress/regress-245148.js anyway.

Comment 8

[Bob Clary [:bc] (inactive)]

verified fixed.