245189 - sunbird should not need hacks to build

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

the sunbird build instructions currently tell you to set MOZ_PHOENIX, and
afterward to copy some makefiles and run make there. Ugly hacks.
This should be done properly but setting MOZ_SUNBIRD.

(filing in browser/buildconfig because it touches mostly stuff outside
/calendar, so i need to be able to set proper review flags)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

Patch that should do the work. doesn't include changes to configure, as it is
automaticly generated. 
set MOZ_SUNBIRD to build sunbird.

Comment 2

[Benjamin Smedberg]

Comment on attachment 149711 [details] [diff] [review]
patch v1

> dnl ========================================================
>+dnl = Sunbird
>+dnl ========================================================
>+if test "$MOZ_SUNBIRD"; then
>+   AC_DEFINE(MOZ_SUNBIRD)
>+
>+   MOZ_XUL_APP=1
>+   AC_DEFINE(MOZ_XUL_APP)
>+   MOZ_APP_NAME=sunbird
>+   MOZ_APP_VERSION=`cat $topsrcdir/calendar/sunbird/config/version.txt`
>+fi
>+
>+AC_SUBST(MOZ_SUNBIRD)
>+AC_SUBST(MOZ_XUL_APP)
>+

This is not quite right... you are adding a duplicate AC_SUBST for MOZ_XUL_APP,
when you should be just moving it from above. And you need to move
AC_DEFINE_UNQUOTED(MOZ_APP_NAME) down after this section.

With those changes, r=me (no sr needed)

Comment 3

[Justin Wood (:Callek)]

..should have had "calendar" keyword

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

checked in.