Closed
Bug 245408
Opened 20 years ago
Closed 20 years ago
'position' shouldn't apply to SVG elements
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ian, Assigned: alex)
References
()
Details
Attachments
(1 file)
1.78 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
The 'position' property shouldn't apply to SVG elements. TESTCASE: http://www.hixie.ch/tests/adhoc/svg/mixed/004.xml
Comment 1•20 years ago
|
||
I assume there's a reason for this (and an explicit mention of it in the SVG spec)?
Reporter | ||
Comment 2•20 years ago
|
||
Yeah -- 'position' is not one of the properties mentioned in SVG 1.1 section 6.1, so it doesn't apply to SVG. See: http://www.w3.org/TR/SVG/styling.html
Assignee | ||
Comment 3•20 years ago
|
||
How about this?
Assignee | ||
Updated•20 years ago
|
Attachment #149897 -
Flags: review?(bzbarsky)
Comment 4•20 years ago
|
||
Oh, I see... so CSS only applies to SVG if it's in that white-list.... fun....
Comment 5•20 years ago
|
||
Alex, I'm not going to be in a position to really review anything other than the things I've already promised people I'd try to get to till July 11 at this point... Try dbaron or roc?
Assignee | ||
Comment 6•20 years ago
|
||
(In reply to comment #4) > Oh, I see... so CSS only applies to SVG if it's in that white-list.... fun.... Well, "position" doesn't really make sense for most SVG elements - you can apply it but it hasn't got any effect, apart from maybe inheriting down to other elements. I'm sure the same is true for many CSS property / XHTML elements combinations.
Assignee | ||
Updated•20 years ago
|
Attachment #149897 -
Flags: review?(bzbarsky) → review?(dbaron)
Comment on attachment 149897 [details] [diff] [review] patch to nsCSSFrameConstructor.cpp Please add "-p" to the options you use for diff. Ian, do you think the |svg| element should be allowed to be absolutely positioned? The spec probably says not, but it certainly does make sense when mixing languages.
Reporter | ||
Comment 8•20 years ago
|
||
As far as I'm concerned, the <svg> element is a replaced element as far as the outer CSS world goes. So I'd say sure, position away. Or float, or put inline, or whatever. We should put that in CSS3 Box...
Attachment #149897 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 9•20 years ago
|
||
David, thanks for the review. Do I need sr as well or is r sufficient, given that the code is "SVG-only"?
Attachment #149897 -
Flags: superreview+
Assignee | ||
Comment 10•20 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•