Closed
Bug 245689
Opened 20 years ago
Closed 20 years ago
ftp channels report NS_ERROR_FAILURE when resuming fails, instead of NS_ERROR_NOT_RESUMABLE
Categories
(Core Graveyard :: Networking: FTP, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha2
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
879 bytes,
patch
|
bbaetz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
this is because nsFtpState::Process overwrites mInternalError with NS_ERROR_FAILURE, because R_mdtm returned FTP_ERROR (after setting mInternalError to NS_ERROR_NOT_RESUMABLE)
Assignee | ||
Comment 1•20 years ago
|
||
Assignee: dougt → cbiesinger
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #150105 -
Flags: superreview?(darin)
Attachment #150105 -
Flags: review?(bbaetz)
Assignee | ||
Updated•20 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.8alpha2
Updated•20 years ago
|
Attachment #150105 -
Flags: review?(bbaetz) → review+
Comment 2•20 years ago
|
||
Comment on attachment 150105 [details] [diff] [review] patch FYI, I think I saw this patch included with your patch for 64-bit downloads. sr=darin
Attachment #150105 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 3•20 years ago
|
||
(In reply to comment #2) > FYI, I think I saw this patch included with your patch for 64-bit downloads. could be... I did a "cvs diff" from netwerk/ there... Checking in src/nsFtpConnectionThread.cpp; /cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v <-- nsFtpConnectionThread.cpp new revision: 1.278; previous revision: 1.277 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•2 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•