Closed
Bug 245836
Opened 21 years ago
Closed 21 years ago
nsIContentPolicy should pass the frameelement for loads in frames as aRequestingNode
Categories
(Core :: Graphics: Image Blocking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timwatt)
References
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
mvl
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
from bug 191839 comment 114 and bug 191839 comment 115
> ... pass the frame element for loads in frames.
|
||
Comment 1•21 years ago
|
||
|
|
||
Comment 2•21 years ago
|
||
Comment on attachment 153369 [details] [diff] [review]
Possible fix
This works, sorta, but I'm tempted to change the nsIDOMNode arg back to
nsISupports and say that it should QI to nsIDOMNode or nsIDOMWindow, then pass
in the nsIDOMWindow here when there is no frame element...
Thoughts?
Attachment #153369 -
Flags: review?(mvl)
|
|
||
Updated•21 years ago
|
Attachment #153369 -
Flags: review?(mvl) → review+
|
|
||
Comment 3•21 years ago
|
||
Comment on attachment 153369 [details] [diff] [review]
Possible fix
jst, would you sr?
Attachment #153369 -
Flags: superreview?(jst)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 153369 [details] [diff] [review]
Possible fix
Yeah, that sounds worth doing. But sr=jst either way.
Attachment #153369 -
Flags: superreview?(jst) → superreview+
|
|
||
Comment 5•21 years ago
|
||
Checked in. Filed bug 252027 on the followup change.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•