245903 - no system console output in MinGW builds

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

In MinGW builds, there is no system console output.  Among other things, this
makes debugging SOAP stuff Very Hard.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: preliminary patch from silver

Here's a preliminary patch that James gave me; iirc he said it's not yet ready
for checkin.  But it does work (thanks James!).

Comment 2

[cls]

Attachment: open_osfhandle testcase

I think Silver's on the right track here but running across that MOZ_WINCONSOLE
switch makes me think that we're taking a slight different track with mingw
compared to what msvc does.  I'm guessing that with msvc builds, -console only
works when MOZ_WINCONSOLE is set.  Silver's changes would make -console work
always.  Using /subsystem:console by default may have other consequences. 
Dunno, IANAWP.	Can someone point us to a resource which explains the exact
differences between subsystem:windows & subsystem:console?

For mingw builds, there's something about the -subsystem:windows link option
(set by -mwindows) which causes the console related functions to fail.	Neither
_open_osfhandle nor WriteConsole work when -mwindows is used.	 

Part of me is wondering if what we're attempting ever worked for msvc builds
when linked with /subsystem:windows (ie, when MOZ_WINCONSOLE is not set).  Can
someone with msvc test this using the testcase I've attached?

Comment 3

[cls]

Attachment: use MOZ_WINCONSOLE for mingw

Comment 4

[cls]

Based upon the irc discussion with dmose, mkaply & timeless, the majority of
this problem seems from cygwin doing something funky with console redirection. 
If a mingw build is run using -console from a cmd.exe prompt, then the console
window is opened and receives dump() output if you have that enabled.  (I still
don't think the _open_osfhandle is working in that case though.  The testcase
still fails.) From within a cygwin shell, you can do './mozilla | cat' and that
will print the output as well.  The MOZ_WINCONSOLE patch makes the mingw builds
behave in the same fashion as the msvc builds.  

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 150839 [details] [diff] [review]
use MOZ_WINCONSOLE for mingw

r+sr=dmose.  thanks chris!

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 150839 [details] [diff] [review]
use MOZ_WINCONSOLE for mingw

a=mkaply for 1.7.1

Comment 7

[Benjamin Smedberg]

Comment on attachment 150839 [details] [diff] [review]
use MOZ_WINCONSOLE for mingw

a=me for the aviary1.0 branch

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Checked into the 1.7 branch.  Awaiting the appearance of a fixed1.7.1 keyword.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Checked in on the Aviary 1.0 branch.  Thanks for the patch, guys.