245953 - Update works poorly

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Software Update barely works. 

If you enable or disable the update checking preferences, they do not take
effect until the next time watchForUpdates is called (usually the next time the
app is started). The update service needs to check for pref changes on the
update. branch.

Critical updates should actually show the update UI to the user (perhaps).

The update interval offset system doesn't seem to work at all. Tracking of the
last background update doesn't seem to work, which causes all kinds of other
problems.

Comment 1

[Frank Fridlund]

Adding to this bug:
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040626 Firefox/0.9.1

I upgraded Firefox manually from 0.9 to 0.9.1, and now it shows there is one
update available.  The update is for Firefox 0.9.1, which is currently
installed!  It's not checking the browser version before offering the update.

Comment 2

[[e-mail]]

(In reply to comment #1)
> I upgraded Firefox manually from 0.9 to 0.9.1, and now it shows there is one
> update available.  The update is for Firefox 0.9.1, which is currently
> installed!  It's not checking the browser version before offering the update.

I experience the same thing - Just upgraded from 0.9 to 0.9.1 like you, and now
have this stupid notification. Running Windows XP Sp1 + full updates.

Comment 3

[Michael Lefevre]

comments 1 and 2 are not because of this software issue - they are bug 249015

Comment 4

[Gabe Grayum]

Same problem here. I am running 0.9.1 (just upgraded from 0.9.0 hoping the
updater would be fixed) and everytime I start I still get an update
notification. The updater is completly useless as well, since all it does is
take you to the Firefox site where you can download a new version. What is the
point of that? was the really the intention? The updater should actually update
your software to the latest version without having to download a new version and
reinstall the software.
I just saw the reference to bug 249015 but am still posting as i think this bug
"Updater works poorly" is valid anyway. The updater is quite lame.

Comment 5

[Wolf [:wolf]]

Is there a plan to fix software update so it can handle minor releases? where
the extensoin version doesn't need to be broken.. Such as 0.9.1 was? If 0.9.1
had happened to be a security fix, (which it wasn't), then the users of 0.9
would've needed to be informed and be able to upgrade without the resulting
effects of Bug 249015. with the update prompt never going away.

Comment 6

[Robert Parenton]

(In reply to comment #5)
> Is there a plan to fix software update so it can handle minor releases? where
> the extensoin version doesn't need to be broken.. Such as 0.9.1 was? If 0.9.1
> had happened to be a security fix, (which it wasn't), then the users of 0.9
> would've needed to be informed and be able to upgrade without the resulting
> effects of Bug 249015. with the update prompt never going away.

Bug 249251 has been filed on this issue.

Comment 7

[Aaron Kaluszka]

Bug 248653 and bug 249324 were already filed...

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 1

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 2

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 3

- various problems with update wizard
- hides app update notification icon for that session after the user has
visited the products page
- makes sure the app update info is cleared when no newer versions are present

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 4

- make app update work when extension update is disabled, general code
correctness etc.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 5

make this work for extensions, too. 

I think this is it for the first round.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, part 6

make sure the browser window that contains the product page is focused.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

br & trunk FIXED. 

Comment 15

[Steffen Wilberg]

*** Bug 244824 has been marked as a duplicate of this bug. ***

Comment 16

[Bill Mason]

*** Bug 251464 has been marked as a duplicate of this bug. ***

Comment 17

[Bill Mason]

*** Bug 251385 has been marked as a duplicate of this bug. ***

Comment 18

[Ryan Polk (Quark)]

setting fixed-aviary1.0 for bugfixes checked into branch, for searching purposes.
sorry for bugspam.