245965 - Forcing Visual Bidi through prefs doesn't work

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Simon Montagu :smontagu]

Alex Shensis from IBM drew my attention to this.

Steps to reproduce: 
1) set the bidi.texttype to 3 in prefs or through about:config

2) go to a page with logical bidi text, e.g.
http://smontagu.org/nscpsite/testcases/Bidi/BasicLogical.html
Expected results: right-to-left text should appear backwards
Actual results: right-to-left text appears correctly

3) go to a page with visual bidi text, e.g.
http://smontagu.org/nscpsite/testcases/Bidi/BasicVisual.html
Expected results: right-to-left text should appear correctly
Actual results: right-to-left text appears correctly (so no bug here, but noting
this case for regression testing)

Comment 1

[Simon Montagu :smontagu]

Attachment: Fix

The problem was in nsPresContext::UpdateCharset(), where the visual mode was
always being set from the charset, treading on the pref.

Comment 2

[Simon Montagu :smontagu]

By the way, with this fix setting bidi.controlsTextMode=3 also works on pages
with  Bidi forced to visual.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 150331 [details] [diff] [review]
Fix

r=mkaply

I think roc is out of town...

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 150331 [details] [diff] [review]
Fix

sr=dveditz

Comment 5

[Simon Montagu :smontagu]

Fix checked in.