Closed
Bug 246115
Opened 20 years ago
Closed 20 years ago
Add support for launching calendar to xremote
Categories
(Core Graveyard :: X-remote, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mostafah, Assigned: blizzard)
Details
Attachments
(1 file, 1 obsolete file)
2.57 KB,
patch
|
shaver
:
review+
shaver
:
superreview+
|
Details | Diff | Splinter Review |
This is a feature requested by many of the calendar users. They want to be able to launch the calendar from command line while mozilla/firefox/thunderbird is already running. The change is easy but it depends on whether we want this in or not.
Reporter | ||
Comment 1•20 years ago
|
||
Comment on attachment 150389 [details] [diff] [review] Proposed fix to add calendar support to xremote >+nsresult >+XRemoteService::GetCalendarLocation(const char **_retval) >+{ >+ // get the Compose chrome URL >+ *_retval = "chrome://calendar/content/calendar.xul"; Should this be based on a pref, like GetBrowser and GetMailLocation? >+ else if (aArgument.EqualsIgnoreCase("opencalendar")) { >+ const char * calendarLocation; >+ rv = GetCalendarLocation(&calendarLocation); >+ if ( rv != NS_OK) Bonus whitespace should be removed: if (rv != NS_OK) but it seems like |if (NS_FAILED(rv))| would be better still. >+ nsCOMPtr<nsIDOMWindow> newWindow; >+ rv = OpenChromeWindow(0, calendarLocation, "chrome,all,dialog=no", >+ arg, getter_AddRefs(newWindow)); >+ } Do we want to try to find an existing window if it's open, like Mail does? I think the pref basing and window reuse can go in later, I just wanted to capture them here. Please fix the NS_FAILED thing before checking in, though.
Attachment #150389 -
Flags: superreview?(blizzard)
Attachment #150389 -
Flags: review+
It would be really useful (imo) if the patch addresses the issue described in http://bugzilla.mozilla.org/show_bug.cgi?id=219589#c33. Changing OS->All since the problem is visible on Windows too.
OS: Linux → All
Reporter | ||
Comment 4•20 years ago
|
||
All issues from comment #2 have been addressed. Another review is appreciated.
Attachment #150389 -
Attachment is obsolete: true
Attachment #173764 -
Flags: review?(shaver)
Comment on attachment 173764 [details] [diff] [review] Proposed fix to add calendar support to remote (Ver 2) r+sr=shaver, thanks!
Attachment #173764 -
Flags: superreview+
Attachment #173764 -
Flags: review?(shaver)
Attachment #173764 -
Flags: review+
Reporter | ||
Comment 6•20 years ago
|
||
Comment on attachment 150389 [details] [diff] [review] Proposed fix to add calendar support to xremote Removing request on obsolete patch
Attachment #150389 -
Flags: superreview?(blizzard)
Reporter | ||
Comment 7•20 years ago
|
||
Attachment 150389 [details] [diff] checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•