246264 - nsHttpChannel may leak mResponseHead

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Darin Fisher]

nsHttpChannel may leak mResponseHead.

The leak happens here:

http://lxr.mozilla.org/mozilla/source/netwerk/protocol/http/src/nsHttpChannel.cpp#3533

mResponseHead is usually null, unless this is the second time this channel has
been used to perform a HTTP transaction.  Currently, that can only happen if we
are authenticating the user after prompting for username and password.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

This patch deletes mResponseHead in DoAuthRetry after we set mIsPending to
PR_TRUE.  The idea is to clear the response headers right before setting up the
next request.  I also added an assertion at the location of leak, which really
should have been there before :-)

Thanks to Javier for finding this leak.

Comment 3

[jhp (no longer active)]

Comment on attachment 150477 [details] [diff] [review]
v1 patch

Yep, that took care of it for me.

Comment 4

[Darin Fisher]

fixed-on-trunk

Comment 5

[Bernard Alleysson]

It is a fixed memory leak bug, could it be considered for 1.7.1 ?

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 150477 [details] [diff] [review]
v1 patch

assuming no problems have come out on the trunk, a=sspitzer for 1.7.1

Comment 7

[Darin Fisher]

fixed1.7.1

Comment 8

[Hiro]

It does not chekin to AVIARY_1_0_20040515_BRANCH.
In order to raise quality, please chekin correction of MOZILLA_1_7_BRANCH to
AVIARY_1_0_20040515_BRANCH, without fail.

Comment 9

[Darin Fisher]

fixed-aviary1.0