246382 - Left column is stretched far too wide on www.simtel.net

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P1)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040601 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040601 Firefox/0.8.0+

This seems like a regression of fixing bug 217527.

The site looks good to me in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/2004-05-31
Firefox/0.8.0+
and also good in: Firefox0.9 (1.7 build) 2004-06-08

But the site doesn't look good to me in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040601
Firefox/0.8.0+
and also not good in: Firefox0.9 (1.7 build) 2004-06-11

This seems to correspond with the checkins of bug 217527.

Reproducible: Always
Steps to Reproduce:
1.Visit url
2.
3.

Actual Results:  
Left column far too wide (like 1050px)

Expected Results:  
Normal width for left column (more like 150px)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It was bug 217527 -- I backed that out of the 1.7 branch.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: partly simplified testcase

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: partly simplified testcase

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified testcase

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 150766 [details]
simplified testcase

Expected results:
 * the select should be narrow

Actual results:
* the select is the width of the page

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified testcase

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the problem here is that combobox max-element-width calculation is
fundamentally broken.  (There's a little bit of code in Reflow that duplicates
what's in ReflowCombobox, but the basic problem is ReflowCombobox setting the
max-element-width to the width.)

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Can anyone think of any cases where a combobox's max-element-width
(min-intrinsic) and unconstrained width (intrinsic) should be different?  I'm
thinking there aren't any such cases.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We never wrap combobox OPTIONs, so no, there should be no difference.

Comment 10

[Michael Lefevre]

nominating for aviary1.0 - would be good to fix this so that the fix that caused
it can be applied to the branch.

Comment 11

[James Beaumont-Field]

Bug reproduced using:
Mozilla 1.8a2 (Build ID: 2004070807)
(Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040708)
Windows XP

And

Firefox 0.9 (1.7 Build)
(Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'll try to fix this for the next alpha.

Comment 13

[chris hofmann]

is backing out the patch for http://bugzilla.mozilla.org/show_bug.cgi?id=217527
a good option for PR1 and 1.0 final?

Comment 14

[Michael Lefevre]

chofmann: That was already done - the patch was backed out of the aviary and 1.7
branches shortly after it was put in, so this bug doesn't exist on the branches.

I was guessing that this was marked as a blocker because without it, the other
fix can't go into the branch. Would be nice not to ship 1.0 with the slashdot
regression, but it's clearly better than having this bug...

Comment 15

[chris hofmann]

ok, thanks.  marking fixed aviary1.0 and I guess
http://bugzilla.mozilla.org/show_bug.cgi?id=217527 should now get marked + so we
can try to get the fix that solves both problems

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also the patch on bug 246999.

Comment 17

[Michael Lefevre]

this isn't fixed on aviary - it was never a bug there. given that the other bug
has been minused, removing blocking flags here along with the keyword.

Comment 18

[Bill Mason]

*** Bug 256096 has been marked as a duplicate of this bug. ***

Comment 19

[Bernd]

The url works now with the fix for bug 246999, but the testcase is still wrong.

Comment 20

[Bernd]

the patch in bug 226637 fixes the remaining problem in the testcase

Comment 21

[Bernd]

the remaining issue with testcase is now fixed by the patch in  bug 226637