246500 - Theme Manager's Use Theme button's tooltip contains a fullstop

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P4)

Description

[Grey Nicholson (they/them)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7) Gecko/20040608 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7) Gecko/20040608 Firefox/0.8.0+

In the Theme Manager, the Uninstall and Update buttons say "Extension" instead
of "Theme".
Also, the Use Theme button's tooltip has a fullstop (period) at the end, unlike
any other tooltip.

Reproducible: Always
Steps to Reproduce:
1.Open Theme Manager
2.Hover over the Uninstall and Update buttons
3.Hover over the Use Theme button

Actual Results:  
2.Uninstall and Update tooltips say "Extension"
3.Use Theme tooltip contains a fullstop

Expected Results:  
2.Uninstall and Update tooltips should say "Theme"
3.Use Theme tooltip should not contain a fullstop

Comment 1

[Grey Nicholson (they/them)]

requesting blocking 1.0

Comment 2

[PikeUK]

Tooltips saying Extension in Theme manager is Bug 246050.

Comment 3

[Grey Nicholson (they/them)]

In that case, this bug can just be about the superfluous fullstop.

Comment 4

[Richard Corbin]

Confirmed.

Status -> NEW

Comment 5

[Mike Goodspeed]

Attachment: Patch

Patch fixes the fullstop at the end of the tooltip and also gets rid of the
space in front of "Use Theme" (right click on a theme).  This is a very minor
and trivial patch, but she is my first, so be gentle.

Comment 6

[PikeUK]

You'll need to request review from a Firefox peer if you want to get your patch
into Firefox:

http://www.mozilla.org/projects/firefox/review.html

Comment 7

[Mike Goodspeed]

OK, thanks for the help, but how do I do that.  I don't know if I should be so
presumptous as to add someone else's email address to the cc box.   Should I
email someone?  Should I add emails to the cc list?  Should I expect that since
ben is the owner of this bug that he will pick it up?  Thanks and sorry for the
ingorance.

Comment 8

[PikeUK]

Click the Edit link next to your patch. On the page that appears is a line
starting with "Review", set the dropdown to "?" and add the e-mail address of
your chosen reviewer (see the list in my previous comment) to the Requestee box.

The Firefox peers own 100s if not 1000s of bugs each so it's unlikely they will
see this bug/patch unless you request review. (And no, you don't need to e-mail
or CC anyone.)

Comment 9

[Michael Lefevre]

Comment on attachment 153082 [details] [diff] [review]
Patch

moving some easy reviews to mconnor who should be getting to them faster than
Ben

Comment 10

[Blake Ross]

Plussing this because that space before Use Theme is just noticeable and sloppy.
Can someone drive this in for us?

Comment 11

[Steffen Wilberg]

Attachment: also add padding in Winstripe

Like the previous patch, this removes the fullstop and the inital space from
cmd.useTheme.label.
But without this space, there is not enough padding between the button image
and the button label. So we have to do The Right Thing(TM) and add the padding
in extensions.css, like already done for the Uninstall and Update buttons.
Pinstripe already takes care of this button:
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#79

Qute (for Thunderbird) looks better without the padding IMHO.

I take comment 10 as r+. I'll check this in once the tree reopens.

Comment 12

[Steffen Wilberg]

Checked in br & trunk 2004-07-21 04:59/05:00.

Comment 13

[Ryan Polk (Quark)]

setting fixed-aviary1.0 for bugfixes checked into branch, for searching purposes.
sorry for bugspam.