246512 - H1 { text-align: left } should be removed from content_style.css

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Tsahi Asher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.6) Gecko/20040113

the old css file of the help files, content_style.css, has this rule in it:

H1 { text-align: left }

left align is the default for html documents with Left To Right (LTR)
orientation, so this rule doesn't add anything. on the other hand, on RTL
documents (i.e. when the help is translated to a RTL language such as hebrew),
text is aligned right, and this rule disrupts the text display, and has to be
disabled (commented out).

since i assume we will be using this file at least in the next release, and
maybe even for a subsequent one, i ask to remove this rule and save me this
little headache.

Reproducible: Always
Steps to Reproduce:

Comment 1

[R.J. Keller]

Attachment: Patch - removes line

Comment 2

[[e-mail]]

Comment on attachment 150619 [details] [diff] [review]
Patch - removes line

What about helpFileLayout.css?

Comment 3

[Tsahi Asher]

the only problem with that file is that it has

.makeLeftMargin {
	margin-left: 25px;
}

which may be better replaced with

.makeLeftMargin {
	-moz-margin-start: 25px;
}

but i don't know where is this rule used.

Comment 4

[R.J. Keller]

Fix checked in.

Comment 5

[Stefan [:stefanh]]

v (even though we're not using that file anymore...)