246556 - M17rc3 crashes [@ nsGenericHTMLElement::RecreateFrames] [@ f2416033]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Radek 'sysKin' Czyz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+

I've been experiencing many crashes with this nightly. Non-clean profile, but
Silver made me fill a big so he can fix it. Here you go.

Talkback # TB89954H, TB89659X, TB89439M, TB89437Y

Reproducible: Sometimes
Steps to Reproduce:
1. Be unlucky with 1 day old profile

Comment 1

[James Ross]

Attachment: Null-check mDocument

This is an inspection patch, based on the crash location in the talkback
reports and the fact most other uses of mDocument include null-checks.

Comment 2

[James Ross]

Comment on attachment 150653 [details] [diff] [review]
Null-check mDocument

This patch is against TRUNK, but it'll need applying to the Aviary branch too.

Comment 3

[Bernard Alleysson]

requesting blocking1.7 because it's currently topcrash #4 and there's a patch to
review

Comment 4

[Jay Patel [:jay]]

Adding M17rc3 to summary and topcrash keyword for tracking...this is a topcrash
for Mozilla 1.7 rc3.

Comment 5

[Jay Patel [:jay]]

*** Bug 246698 has been marked as a duplicate of this bug. ***

Comment 6

[Radek 'sysKin' Czyz]

Any chances of having it fixed before Firefox 0.9? Please pretty please, it's
just a null check, it can be reviewed in 30 seconds and even if it's wrong (not
that it is) it will not cause any problems.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 150653 [details] [diff] [review]
Null-check mDocument

r+sr=jst

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 150653 [details] [diff] [review]
Null-check mDocument

Trivial null check, if we're still taking changes for 1.7, this is a no-risk
crash fix. No idea how frequent of a crash tho...

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 150653 [details] [diff] [review]
Null-check mDocument

Leaf says a=leaf

Comment 10

[Johnny Stenback (:jst)]

Fix checked in on the 1.7 branch.

Comment 11

[Johnny Stenback (:jst)]

Fixed on the trunk too. Thanks for the fix!

Comment 12

[David Epstein]

Verified on Mozilla 1.7 branch. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.7) Gecko/20040617. I haven't experienced any crashes with older profiles.
Verified code checkin for this build in nsGenericHTMLElement::RecreateFrames()
in nsGenericHTMLElement.cpp .
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsGenericHTMLElement.cpp#539

Comment 13

[Adam Hauner]

*** Bug 248975 has been marked as a duplicate of this bug. ***