246575 - Drawing surface leak

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Sergei Dolgov]

BeOS version of bug 206561:
"nsRenderingContextGTK addrefs mSurface but only releases mOffscreenSurface. 
mOffscreenSurface appears to be the "original" surface for the rendering
context, it's identical to mSurface in the original Init() codepath. Similarly
initializing it here in Init() stops us leaking the surface because the
NS_ADDREF(mSurface) is balanced by NS_IF_RELEASE(mOffscreenSurface) in the
rendering context destructor. This doesn't seem to create any new problems." -
Robert O'Callahan   (http://bugzilla.mozilla.org/show_bug.cgi?id=206561#c11)

Fix is very similar to GTK version too

Separating it from BeOS bug 239813 for time-saving and clearness.

Comment 1

[Sergei Dolgov]

Attachment: patch. (diff -up4)

obvious patch

Comment 2

[Sergei Dolgov]

Comment on attachment 150659 [details] [diff] [review]
patch. (diff -up4)

Decaf, time to fix leak - asking review

Comment 3

[tqh]

Comment on attachment 150659 [details] [diff] [review]
patch. (diff -up4)

r=[e-mail]

Comment 4

[Sergei Dolgov]

fixed.
"2004-06-14 10:09 Bug 246575 Drawing surface leak fix.
r=[e-mail]. No sr required - BeOS port-only change"

Comment 5

[Niels Reedijk]

Checkin on AVIARY by db48x%yahoo.com 
 
"Check in several BeOS bugs that are already checked in on the trunk. All are 
r=twh ([e-mail]) except the last which is r=Sergei Dolgov 
([e-mail]). a=carte blanche ([03:53:40] 
<nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for 
any change that involves the beos-only code)"