Closed
Bug 246575
Opened 20 years ago
Closed 20 years ago
Drawing surface leak
Categories
(Core Graveyard :: GFX: BeOS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sergei_d, Assigned: sergei_d)
Details
(Keywords: fixed-aviary1.0, memory-leak)
Attachments
(1 file)
|
771 bytes,
patch
|
thesuckiestemail
:
review+
|
Details | Diff | Splinter Review |
BeOS version of bug 206561: "nsRenderingContextGTK addrefs mSurface but only releases mOffscreenSurface. mOffscreenSurface appears to be the "original" surface for the rendering context, it's identical to mSurface in the original Init() codepath. Similarly initializing it here in Init() stops us leaking the surface because the NS_ADDREF(mSurface) is balanced by NS_IF_RELEASE(mOffscreenSurface) in the rendering context destructor. This doesn't seem to create any new problems." - Robert O'Callahan (http://bugzilla.mozilla.org/show_bug.cgi?id=206561#c11) Fix is very similar to GTK version too Separating it from BeOS bug 239813 for time-saving and clearness.
|
Assignee | |
Comment 1•20 years ago
|
||
obvious patch
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 150659 [details] [diff] [review] patch. (diff -up4) Decaf, time to fix leak - asking review
Attachment #150659 -
Flags: review?(thesuckiestemail)
Comment on attachment 150659 [details] [diff] [review] patch. (diff -up4) r=thesuckiestemail@yahoo.se
Attachment #150659 -
Flags: review?(thesuckiestemail) → review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
fixed. "2004-06-14 10:09 Bug 246575 Drawing surface leak fix. r=thesuckiestemail@yahoo.se. No sr required - BeOS port-only change"
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 5•20 years ago
|
||
Checkin on AVIARY by db48x%yahoo.com "Check in several BeOS bugs that are already checked in on the trunk. All are r=twh (thesuckiestemail@yahoo.se) except the last which is r=Sergei Dolgov (sergei_d@fi.tartu.ee). a=carte blanche ([03:53:40] <nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for any change that involves the beos-only code)"
Keywords: fixed-aviary1.0
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•