246618 - Show Default Download Folder in Downloads Window when in AutoDownload mode

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

When AutoDownload is used (by default) we should show where we're downloading
files to by default in the download manager window - especially on Windows and
Linux where it's a new convention to automatically download files to the
desktop. This provides a pointer to where the user's files are.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

patch - replace "Options" button by info area that shows download location.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: screenshot

Comment 3

[Brent Harsh]

I was going to report another issue with the default download folder, but
decided it belonged in this bug report.  I used tweakUI in WinXP to move the
location of my desktop off of the C: drive, to keep C clear for the pagefile and
system files only (this was done long before installing Firefox).  Downloading a
file with firefox seems to have re-created a C:/Documents and
Settings/<user>/Desktop folder instead of using the F:/Doc.../Desktop folder. 
What confused me is that in tools/options menu the default location simply said
"desktop", so I think that Firefox is making the assumption that this is on the
C: drive.  I can manually change the default location to F:/Docu../Desktop so no
big deal, but if someone is already looking at this area, perhaps there's a way
to obtain the "desktop" location from the system instead of assuming it's on
c:/.  About to play with FF.9 (that's what I was downloading <grin>) now that
I've found where firefox stuck it!

Comment 4

[Ali Ebrahim]

*** Bug 246598 has been marked as a duplicate of this bug. ***

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

br & trunk FIXED. 

Comment 6

[Steffen Wilberg]

Using Windows XP here.

I get nearly all special folder icons including Desktop, My Pictures, My Music,
Favorites, Recent Documents, Start Menu\Programs, Recycled, Downloaded Progam
Files, etc.

But: I get neither the harddisk icon nor the "My Documents" icon. I've moved "My
Documents" to its own harddisk partition. Selecting that folder should either
display the "My Documents" icon, like Explorer does, or at least a harddisk
icon. But there's no icon at all in the download manager.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

(In reply to comment #6)
> But: I get neither the harddisk icon nor the "My Documents" icon. I've moved "My
> Documents" to its own harddisk partition. Selecting that folder should either
> display the "My Documents" icon, like Explorer does, or at least a harddisk
> icon. But there's no icon at all in the download manager.

Steffen, you could try and extend the changes I made to nsIconChannel.cpp in the
dependent bug (246616)... file a new bug with the patch attached if you can get
something that works. 

Comment 8

[Worcester12345]

I was told this error I get is part of this bug. 

Here is the posting, FYI. Hope it helps "the cause":

[quote="TheOneKEA"][quote="sasquatch"]got this error, not sure if with the
build, or with download manager tweak extension:

[img]http://img8.imageshack.us/img8/183/error9.jpg[/img]


Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040624
Firefox/0.9.0+ (bangbang023)

Download Manager Tweak 0.5.0[/quote]

Bug 246618.

Uninstall the Download Manager Tweak extension and install this instead:

http://www.pryan.org/mozilla/site/TheOneKEA/extensions/downloadtweak_051.xpi[/quote]