246694 - 64-bit build: incorrect handling of password policy response

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP Tools, defect)

Description

[Mark Smith [:mcs]]

In a 64-bit compilation (where sizeof(long) != sizeof(int), the LDAP command
line tools do not correctly handle the password policy response.  This is
because ints are passed to ber_scanf() instead of longs.  Reported by Netscape.

Comment 1

[Mark Smith [:mcs]]

Attachment: proposed fix from Netscape

Comment 2

[Mark Smith [:mcs]]

Comment on attachment 150737 [details] [diff] [review]
proposed fix from Netscape

r=mcs.

Comment 3

[Mark Smith [:mcs]]

This fix only affects the LDAP command line tools which are not used by Mozilla
client projects.  Fix committed to the trunk:

mozilla/directory/c-sdk/ldap/clients/tools/common.c
  new revision: 5.12; previous revision: 5.11
     Fix bug # 246694 - 64-bit build: incorrect handling of
                        password policy response.
       The 'i' format specifier to ber_scanf() requires a long arg, not int.

Comment 4

[Mark Smith [:mcs]]

Attachment: additional fix from David Boreham: liblber enums are longs

Comment 5

[Mark Smith [:mcs]]

One additional small fix committed:

mozilla/directory/c-sdk/ldap/clients/tools/common.c
  new revision: 5.13; previous revision: 5.12
    Additional fix for bug #246694 - 64-bit build: incorrect handling of
    password policy response.