246783 - Need support for params of type base64binary

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Harshal Pradhan]

This is often used for moving binary data over SOAP in a resonably efficient manner.

Comment 1

[Harshal Pradhan]

Attachment: SOAP patch.

This works, but I am not yet entirely happy. Too much cut paste code, could use
some refactoring. In any case, this is not finished since this ended up
exposing a lot of bugs in wsp code.

Comment 2

[Harshal Pradhan]

Attachment: Fixes for array params in web service proxy code

Comment 3

[Harshal Pradhan]

Attachment: Testcase

This is a testcase that uses SUN's public interop testing endpoint.

Comment 4

[Harshal Pradhan]

Comment on attachment 150828 [details]
Testcase

Ugh ... sorry for the spam

Comment 5

[Harshal Pradhan]

Attachment: wsp fixes v2

I'd like to get at least this part in. All bugfixes. All stuff that looks like
its been broken since the initial checkin.

wspinfoservice.cpp

- There is no leading arg generated in the callback methods. A trailing context

  arg is used for the context, the comment is just wrong. The k-1 screws up the

  arg that is pointed to by size_is().

wspproxy.cpp

- VariantToArrayValue would deref a null pointer instead of assigning to it.
- VariantToOutParam passed in nsXPTCVariant* into this VariantToArrayValue.
  It expected a pointer into an array of nsXPTCMiniVariant.
  Pointer arithmetic on the pointer to the base struct blows up since the size
  of the two structs is not the same. I split things up into two separate
  params to avoid the mess.
- xptcall expects the type in the nsXPTCVariant to be set correctly. Make 
  VariantToOutParam set it and make sure that things dont blow up.
- Also deal with AString types in a couple of places. Looks like this code
  was not updated after the new string types were added to idl. (This was
needed
  to get some of the test code in webservices/proxy/test to work.)

Comment 6

[Harshal Pradhan]

Comment on attachment 151011 [details] [diff] [review]
wsp fixes v2

jst, I really don't know who amongst currently active hackers knows this code.
Could you suggest someone or please have a look yourself.

Comment 7

[Harshal Pradhan]

Attachment: SOAP patch v2

This is ready for review. (It depends on the wsp patch above. 

The needs for encoding the type are slightly different since base64binary was
not in the 1999 schema spec but is in the 2001 spec. So we should not use the
mapped uri of the schema for the type namespace. So the encoding part is a
little bit different from all the other simple encoders.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 151011 [details] [diff] [review]
wsp fixes v2

r+sr=jst

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 151447 [details] [diff] [review]
SOAP patch v2

r+sr=jst

Comment 10

[Harshal Pradhan]

Thanks for the reviews. Checked in.