Closed
Bug 247047
Opened 21 years ago
Closed 21 years ago
[aviary branch] [patch] extra semicolon in nsSoftwareUpdate.cpp
Categories
(Firefox :: Installer, defect)
Tracking
()
VERIFIED
FIXED
Firefox1.0beta
People
(Reporter: kajtzu, Assigned: bugs)
References
Details
Attachments
(1 file)
|
602 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040407 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040407 Firefox/0.8
Firefox 0.9 fails to build with gcc 3.4.0 because of an extra colon in
nsSoftwareUpdate.cpp.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
Reporter | |
Comment 1•21 years ago
|
||
Assignee: bryner → xpi-engine
Component: Build Config → Installer: XPInstall Engine
Product: Firefox → Browser
QA Contact: asa
Summary: patch: gcc34: extra colon in nsSoftwareUpdate.cpp → patch: gcc34: extra semicolon in nsSoftwareUpdate.cpp
Version: unspecified → Trunk
Attachment #150917 -
Flags: superreview?(dveditz)
Attachment #150917 -
Flags: review+
Attachment #150917 -
Flags: superreview?(dveditz)
Attachment #150917 -
Flags: review?(bugs)
Attachment #150917 -
Flags: review+
Assignee: xpi-engine → bugs
Component: Installer: XPInstall Engine → Installer
Product: Browser → Firefox
QA Contact: bugzilla
Version: Trunk → unspecified
reporter: please use cvs diff so that people will recognize that you're patching
a branch.
Summary: patch: gcc34: extra semicolon in nsSoftwareUpdate.cpp → [avairy branch] patch: gcc34: extra semicolon in nsSoftwareUpdate.cpp
|
|
Reporter | |
Comment 3•21 years ago
|
||
I'll try to remember it next time. ;-( Reason for format was that I was patching
a SRPM.
*** Bug 246947 has been marked as a duplicate of this bug. ***
|
||
Comment 5•21 years ago
|
||
*** Bug 248119 has been marked as a duplicate of this bug. ***
|
|
||
Comment 6•21 years ago
|
||
If someone actually wants the CVS diff for the trivial patch, it's in bug 248119.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Summary: [avairy branch] patch: gcc34: extra semicolon in nsSoftwareUpdate.cpp → [aviary branch] [patch] extra semicolon in nsSoftwareUpdate.cpp
|
|
||
Updated•21 years ago
|
Attachment #150917 -
Attachment description: patch for nsSoftwareUpdate.cpp → one-line patch for nsSoftwareUpdate.cpp
Attachment #150917 -
Flags: review?(mconnor)
|
|
||
Comment 7•21 years ago
|
||
er... not sure what happened with the flags there...
|
|
||
Updated•21 years ago
|
Attachment #150917 -
Flags: review?(mconnor) → review+
|
|
||
Updated•21 years ago
|
Component: Installer → Installer: XPInstall Engine
Product: Firefox → Browser
Version: unspecified → Trunk
|
|
||
Comment 8•21 years ago
|
||
Comment on attachment 150917 [details] [diff] [review]
one-line patch for nsSoftwareUpdate.cpp
clearing review request associated with Browser product
Attachment #150917 -
Flags: review?(bugs)
|
|
||
Comment 9•21 years ago
|
||
and now, back to Firefox
Component: Installer: XPInstall Engine → Installer
Product: Browser → Firefox
Target Milestone: --- → Firefox1.0beta
Version: Trunk → unspecified
|
||
Comment 10•21 years ago
|
||
David Baron fixed this earlier today:
http://bonsai.mozilla.org/cvsquery.cgi?branch=AVIARY_1_0_20040515_BRANCH&branchtype=match&date=explicit&mindate=2004-07-01+18%3A02&maxdate=2004-07-01+18%3A02
Marking FIXED
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → installer
You need to log in
before you can comment on or make changes to this bug.
Description
•