Closed
Bug 247287
Opened 21 years ago
Closed 21 years ago
[FIXr]abs pos rtl block uses left static pos, not right static pos (bidi element with left:auto;right:auto)
Categories
(Core :: Layout: Positioned, defect, P1)
Core
Layout: Positioned
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: ian, Assigned: bzbarsky)
References
()
Details
(Keywords: rtl)
Attachments
(1 file)
1.39 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
asa
:
approval1.7.5-
|
Details | Diff | Splinter Review |
An absolutely positioned element with left:auto;right:auto (in static position)
doesn't take into account the directionality of the element when deciding
whether to use the 'left' or 'right' property for alignment when they are both
set to 'auto' as it should according to CSS2.1 section 10.3.7, first paragraph
after the equation.
TESTCASE: http://www.hixie.ch/tests/adhoc/css/box/absolute/022.html
Tested with FF0.9, sorry if the trunk has already fixed this. Also, I think this
might be a dupe but I couldn't find the other bug.
(o120248)
![]() |
Assignee | |
Comment 1•21 years ago
|
||
Note
http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsHTMLReflowState.cpp#984
-- has this changed from CSS2?
![]() |
Assignee | |
Comment 2•21 years ago
|
||
![]() |
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 153071 [details] [diff] [review]
If the spec _has_ changed, this is the fix
The blame for that comment is troy back in 2000, so it may be that the comment
is just wrong... My reading of CSS2 certainly doesn't agree with that comment.
Attachment #153071 -
Flags: superreview?(dbaron)
Attachment #153071 -
Flags: review?(dbaron)
Comment on attachment 153071 [details] [diff] [review]
If the spec _has_ changed, this is the fix
I've removed a whole bunch of other instances of that pattern.
Attachment #153071 -
Flags: superreview?(dbaron)
Attachment #153071 -
Flags: superreview+
Attachment #153071 -
Flags: review?(dbaron)
Attachment #153071 -
Flags: review+
![]() |
Assignee | |
Comment 5•21 years ago
|
||
Comment on attachment 153071 [details] [diff] [review]
If the spec _has_ changed, this is the fix
In that case, I think this is worth taking on the 1.7 branch.
Attachment #153071 -
Flags: approval1.7.2?
![]() |
Assignee | |
Updated•21 years ago
|
Assignee: nobody → bzbarsky
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
Summary: abs pos rtl block uses left static pos, not right static pos (bidi element with left:auto;right:auto) → [FIXr]abs pos rtl block uses left static pos, not right static pos (bidi element with left:auto;right:auto)
Target Milestone: --- → mozilla1.8beta
![]() |
Assignee | |
Comment 6•21 years ago
|
||
Checked in for 1.8a3 or 1.8b or whatever this next milestone is.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 7•21 years ago
|
||
Comment on attachment 153071 [details] [diff] [review]
If the spec _has_ changed, this is the fix
If this didn't make it into Firefox 1.0 then we probably don't want it in 1.7.x
which is supposed to be a gecko equivalent for Firefox 1.0. Please re-request
approval if I'm wrong. Thanks.
Attachment #153071 -
Flags: approval1.7.x? → approval1.7.x-
![]() |
Assignee | |
Comment 8•21 years ago
|
||
No, that's correct. This really needed to go into both 1.7 and aviary, in my
opinion, but approvals just took a long time. :(
Comment 9•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•