247810 - Mozilla Update (update.mozilla.org) needs a Search Feature

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wolf [:wolf]]

Pretty straight forward, filing this now that the site is up as it was futured
on my development list.

Search needs to search,
-- Author, Name, Description, etc..

Comment 1

[Xavier Robin]

Or at least there should be lists of extensions name/author to be able to find
an extension from its name. Currently I use a google search to find extensions :
http://www.google.com/custom?domains=update.mozilla.org&sitesearch=update.mozilla.org

Comment 2

[James Ross]

How about listing All without the comments, and a compressed entry for each? e.g.

+-------------------------------------------------------------------------------+
| ChatZilla 0.9.64c                        Firefox 0.7-0.9+  [*****]  [Install] |
+-------------------------------------------------------------------------------+

Or something? :)

Comment 3

[Nicolas Dietrich [:nidi]]

i'm for a simple search field in a box upon or below the categories box.

Comment 4

[Wolf [:wolf]]

*** Bug 255707 has been marked as a duplicate of this bug. ***

Comment 5

[alanjstr]

*** Bug 257232 has been marked as a duplicate of this bug. ***

Comment 6

[TuringT]

Mozilla Update needs an alphabetical index. The "Categories:All" page dosn't
help to find an extension by name (unless the name starts with 'A'). The "jump
to:" links in this category should be indexed by letter, not by page as it is now.

A search tool is also necessary, but is more heavy on the server and most
searches would be not required if there was an index.

Comment 7

[Anne (:annevk)]

*** Bug 257345 has been marked as a duplicate of this bug. ***

Comment 8

[Prognathous]

As a workaround one can use the following bookmark:

URL: http://www.google.com/search?&q=%s+site%3Aupdate.mozilla.org&btnG=Search
Keyword: mozupdate

This way, all I have to do to find the BiDi UI extension is type "mozupdate
bidi". Works like charm :-)

Prog.

Comment 9

[Wolf [:wolf]]

*** Bug 261255 has been marked as a duplicate of this bug. ***

Comment 10

[Wolf [:wolf]]

*** Bug 262632 has been marked as a duplicate of this bug. ***

Comment 11

[baris]

Search option is definately a need. Searching through google is pointer, cache
is not always update, besides, it's unfortunate to say that google search our
content better than we do. 

Comment 12

[Wolf [:wolf]]

This will be done, no further evanglism comments are needed, thanks. :-)

Comment 13

[Wolf [:wolf]]

*** Bug 266515 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: search.php

What I have so far.  This is NOT for checkin.

Comment 15

[alanjstr]

See bug 256972

You reuse things like $_GET["rating"] instead of the variable that you already
retrieved it into.

If the purpose of the first query is to merely get the total number, it should
be a select count(*)

I am not sure what you're trying to do with all those
   eval("\$sel".$_GET["rating"]." = 'selected';");
statements.  How about some comments in there and some whitespace.

Move your javascript display block/none into a function instead of having it
inline.  Make it reusable by passing in the ID and 'show'/'hide'

Character limits on the text boxes

What is an "update" that you're searching for?

shouldn't it be "selected='selected'" for an option?

Why are $sql2 and $sql3 separate?  Can't they be part of the initial query?

Use a page-wide stylesheet instead of inline styles.

Comment 16

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #15)
> I am not sure what you're trying to do with all those
>    eval("\$sel".$_GET["rating"]." = 'selected';");
> statements.  How about some comments in there and some whitespace.
That code shouldn't be used by anyone else (or even me, when I have time to
clean this up).  It's an ugly hack to make the select boxes have the right item
selected when you load the page.

> What is an "update" that you're searching for?
As far as I can tell, we have extensions, themes, and updates.  I don't know
what updates actually are.

Comment 17

[alanjstr]

(In reply to comment #16)
> (In reply to comment #15)
> > I am not sure what you're trying to do with all those
> >    eval("\$sel".$_GET["rating"]." = 'selected';");
> > statements.  How about some comments in there and some whitespace.
> That code shouldn't be used by anyone else (or even me, when I have time to
> clean this up).  It's an ugly hack to make the select boxes have the right item
> selected when you load the page.

I understood that part.  I'm just not sure I like the HTML it generates.

> 
> > What is an "update" that you're searching for?
> As far as I can tell, we have extensions, themes, and updates.  I don't know
> what updates actually are.

The site hosts updates, but they're updates of themes and extensions and that's
what the web service is for.  If you're manually looking to see if there is an
update out for something you've downloaded, you'd still search for an E or a T.

Comment 18

[José Jeria]

If I may say something about the html, please use lowercase, now its mixed. Both
the tags and the attributes. Same with the quotation, sometimes it is double
quotes, sometimes single quotes.

And instead of using font tags, use CSS to style the text.

Comment 19

[Wolf [:wolf]]

$sql2 and $sql3 are seperate intentionally. $sql2 exists because $sql itself and
MySQL in general, doesn't handle the sorting method required for the
extension/theme page listings. Touching $sql usually results in more bugs than
anything beneficial, therefore it is *not* recommended.

Since the code around the eval()s clearly states its a hack and not for
production use. I don't think anybody cares whether the HTML it creates is nice
or not.

Comment 20

[alanjstr]

(In reply to comment #19)
> $sql2 and $sql3 are seperate intentionally. $sql2 exists because $sql itself and
> MySQL in general, doesn't handle the sorting method required for the
> extension/theme page listings. Touching $sql usually results in more bugs than
> anything beneficial, therefore it is *not* recommended.

How about some comments in the code, or better named variables, so that people
can figure out what's going on?  

Comment 21

[:Gavin Sharp [email: [e-mail]]]

*** Bug 270695 has been marked as a duplicate of this bug. ***

Comment 22

[Wolf [:wolf]]

*** Bug 270770 has been marked as a duplicate of this bug. ***

Comment 23

[Arnoud Berendsen]

Add update.mozilla.org to Summary to make this bug more discoverable

Comment 24

[Wolf [:wolf]]

Bulk Moving Web Site bugs to new component.
(Filter: massumowebsitespam)

Comment 25

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: quicksearch.php

Sorry, I dont have time to work on this any more.  Quicksearch.php is a
somewhat stripped-down version of search.php that doesn't offer the advanced
search features.

Comment 26

[Andreas Borutta]

I suggest as one of several views one like
http://texturizer.net/firefox/extensions/alpha.html
which means: showing the names of all extensions on one single webpage.
That allows a fast overview.
Andreas Borutta

Comment 27

[alanjstr]

Make the results an unordered list consisting of title (linking to Moreinfo), a
line break, and then the first 250 characters of the summary.  Then you'll get
my signoff.  At this point, a quick and clean result list will suffice.

Comment 28

[Jens Bannmann]

I noticed both attachments seem to use their own form input fields - how does
this relate to the search box in UMO page header, which lets you select "entire
site", "extensions" and "themes"? And what's meant with "entire site" -
extensions+themes, or mozilla.org?

Comment 29

[(not currently active) Ted Mielczarek]

I have a slightly tweaked patch that uses the header search bar to hook up to
this search.  I'll tweak the results format and post it in a bit.

Comment 30

[(not currently active) Ted Mielczarek]

Attachment: Even more stripped down quicksearch.php

Stripped to a minimum, but useful.

Comment 31

[(not currently active) Ted Mielczarek]

Attachment: inc_header.php changes to use quicksearch.php for searching

Change the header to use this new search.  Doesn't fill in the search fields
with the current query params, however.

Comment 32

[alanjstr]

Comment on attachment 169962 [details]
Even more stripped down quicksearch.php

This doesn't seem to be using the global header, but it does have the footer.

Comment 33

[(not currently active) Ted Mielczarek]

Attachment: Cleaned up quicksearch.php

Cleaned up extra header cruft.	Also changed results so each results div has
class="searchresult"

Comment 34

[alanjstr]

Comment on attachment 169963 [details] [diff] [review]
inc_header.php changes to use quicksearch.php for searching

Line breaks between the Options, please.

Comment 35

[(not currently active) Ted Mielczarek]

Attachment: Updated inc_header.php changes

Slight cleanup

Comment 36

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checking in mozilla/webtools/update/quicksearch.php;
/cvsroot/mozilla/webtools/update/quicksearch.php,v  <--  quicksearch.php
initial revision: 1.1
done
Checking in mozilla/webtools/update/core/inc_header.php;
/cvsroot/mozilla/webtools/update/core/inc_header.php,v  <--  inc_header.php
new revision: 1.7; previous revision: 1.6
done

Comment 37

[alanjstr]

Needed on Branch

Comment 38

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Branch:
Checking in mozilla/webtools/update/core/inc_header.php;
/cvsroot/mozilla/webtools/update/core/inc_header.php,v  <--  inc_header.php
new revision: 1.6.2.1; previous revision: 1.6
done
Checking in mozilla/webtools/update/quicksearch.php;
/cvsroot/mozilla/webtools/update/quicksearch.php,v  <--  quicksearch.php
new revision: 1.1.2.1; previous revision: 1.1
done