248029 - XUL text with right-to-left text in mixed languages renders wrong

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Simon Montagu :smontagu]

I came across this testing bug 91312. With or without the patch, tooltips
containing a right-to-left override character render incorrectly.

Comment 1

[Simon Montagu :smontagu]

Attachment: testcase

Comment 2

[Simon Montagu :smontagu]

Attachment: testcase

Opening the testcase in a tab and comparing the tab title with the header shows
that the bug is in any XUL text.

Comment 3

[Simon Montagu :smontagu]

Attachment: Mixed language bidi tooltips

It gets worse... Most of the tooltips in this testcase are displayed wrong even
with Ilya's patch from bug 91312.

The good news is that I have a handle on the problem: CalculateCharType() in
nsBidiPresUtils::RenderText needs to scan the text backwards when level is odd.
I think that will solve all the issues.

Comment 4

[Simon Montagu :smontagu]

Attachment: patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 152448 [details] [diff] [review]
patch

I don't understand this code very well, but the comment and code make sense.

Comment 6

[Simon Montagu :smontagu]

Fix checked in.

Comment 7

[Aleksey Nogin]

This commit have added a warning on brad TBox:

+layout/base/src/nsBidiPresUtils.cpp:1053
+ `nscoord xEndRun' might be used uninitialized in this function

Comment 8

[Simon Montagu :smontagu]

That warning sounds bogus to me. xEndRun is initialized and used inside two
different |if (level & 1)|, and level can't change between the two.

Comment 9

[Simon Montagu :smontagu]

Ilya, this is the bug I mentioned to you on Friday. Can you verify that the bug
is fixed on Linux?

Comment 10

[Ilya Konstantinov]

Indeed fixed (Linux 20040821).