248102 - Splashscreen mozilla.bmp is removed during Upgrade

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Alex Pircher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040616

During Upgrade (Moz 1.6 de-AT to Moz 1.7 de-AT) with
Installer the Splashscreen mozilla.bmp is removed.


Reproducible: Always
Steps to Reproduce:
1. Install Mozilla 1.6 de-AT
2. Upgrade with Installer to Mozilla 1.7 de-AT
3.

Actual Results:  
Installer should not remove the Splashscreen mozilla.bmp


Expected Results:  
Removed mozilla.bmp

Comment 1

[Frank Wein [:mcsmurf]]

I think this is wanted, anyway the installer asks you if you want to delete the
files that are still in the folder you want to install to. But you should always
install Mozilla in a clean folder.
btw: There is no installer for 1.7 de-AT yet...so you must have used another
installer than the unofficial one from http://germaninstaller.sourceforge.net/ :)

Comment 2

[Alex Pircher]

I used the original Mozille 1.7-Installer and afterwards installed
the languagepack via de-AT-XPI. It didn't know if it is useful to
specify also this.

However, during installation the warning says "Unrecognized 3rd party
components will be removed from this directory to prevent version
incompatibilities and will have to be re-installed. ..."

IMO should mozilla.bmp be a recognized component and therefore not
be removed.

Comment 3

[Frank Wein [:mcsmurf]]

I think this bug should be invalid, because we don't know what files are "good"
and what are "evil" and can be kept. So we do this file deletion in the folder
you install in.

Comment 4

[Alex Pircher]

There must be already a list of "good" files, because it says
"Unrecognized 3rd party components". So why don't make the
Splashscreen recognizeable?

Comment 5

[Patrick]

Both Frank and Alex are right. Frank because this is the consequence of bug
210731. There it was decided that basically the entire moz folder needs to be
cleared except for 

  file: install_status.log
   dir: plugins
   dir: uninstall

And Alex because I think mozilla.bmp can be qualified as a "good" file, which
makes this a valid bug -> Confirming.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Fix

Add mozilla.bmp to the exclude list.

Comment 7

[Sean Su]

Comment on attachment 151464 [details] [diff] [review]
Fix

are there any other files besides just mozilla.bmp?

r=ssu, if mozilla.bmp is the only one.

Comment 8

[Alex Pircher]

Sean, didn't recognize any other things missing after the upgrade,
except the usual 3rd party components.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 151464 [details] [diff] [review]
Fix

sr=dveditz

Comment 10

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 11

[Alex Pircher]

Just upgraded from 1.7 to 1.7.3, mozilla.bmp has been removed
again. Was the fix checked in into 1.7.3 or before?

Comment 12

[timeless]

Comment on attachment 151464 [details] [diff] [review]
Fix

after 1.7, 1.7.x so far have all been security releases, so even if it was on
the branch (which it wasn't), it wouldn't have made it into the release.

you could try 1.8a5, it should work there.

Comment 13

[timeless]

this is fixed on trunk:
mozilla/xpinstall/packager/windows/config.it 	1.142

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 151464 [details] [diff] [review]
Fix

a=asa for 1.7.x checkin.