24817 - No filenames generated for index files on d/l

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P4)

Description

[Sean Richardson]

* Overview:
If a page with no filename part to its URL (ends in "/"), no filename is 
generated and passed to the "Save File" or "Save As" dialog, for both
File>Save page as... and [Context Menu]>Save Link as... NN 4.7 generates
a filename based on the domain name, e.g., "www_mozilla_org.html".

* Steps to reproduce:
1. View this bug report in Mozilla.
2. Right-click on the "URL" link above, select "Save Link As..."
3. Observe the filename portion of the "Save File" or "Save As" dialog and 
   cancel it.
4. Left-click on the "URL" link above; let the page load.
5. Use File>Save page as... or the context menu equivalent to begin saving it.
6. Observe the filename portion of the "Save File" or "Save As" dialog and 
   cancel it.

* Actual Results:
No filename is generated; none can be seen in step 3 or step 6.

* Expected Results:
A filename based on the domain name, with "." replaced by "_", and the trailing
"/" replaced by ".html".

* Tested with:
2000-01-22-09-M14 nightly binary on Linux custom Slackware 4.0, fvwm2
2000-01-22-08-M14 nightly binary on Windows NT 4.0sp3

* Additional information:
This is not a DUP of either bug 16043, "Saving downloads does not suggest a 
file name", which is a problem with not using filenames in the URL of the file
to be saved, nor, despite the summary, bug 22861, "Default filename not set on 
file download" - in that case, the filename is provided in an HTTP header and 
is not being used.

Comment 1

[Chris McAfee]

over to valeski for a look

Comment 2

[leger]

Setting the keyword all open [4.xp] bugs to 4xp.

Comment 3

[Bill Law]

I'll see about enhancing the generation of the suggested file name to catch this 
case (the code is in nsStreamTransfer::SuggestNameFor in nsStreamTransfer.cpp).  
Setting target milestone to M15.  Shouldn't be too hard, just isn't priority #1 
at the moment.

Comment 4

[don]

Agreed.

Comment 5

[don]

Move to M16 for now ...

Comment 6

[don]

Move to M21 target milestone.

Comment 7

[Jesse Ruderman]

related: bug 31519

Comment 8

[Paul Chen]

nav triage team:

Would be nice to fix, but I don't think we'll get to it for beta1, marking 
nsbeta1-

Comment 9

[Jesse Ruderman]

See also bug 67901, "When saving files, file widget should be initialized with 
page title".  If that bug is fixed, it would still be good to fix this bug for 
the case when the page doesn't give a title.

Comment 10

[Bill Law]

->mozilla0.9.9

Comment 11

[Bill Law]

This works the way suggested, now.

Comment 12

[sairuh (rarely reading bugmail)]

yes, this is working per the fix in bug 115176.

marking verified, whee!