248172 - XMLSerializer corrupts namespace prefixes when XHTML namespace is used

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[William J. Edney]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616

The XMLSerializer corrupts namespace prefixes when the XHTML namespace is used.
Note that the DOM itself contains the correct namespace information (i.e. you
can poke around and get 'namespaceURI's and 'prefix's) but the serializer
corrupts the output.

Note that this did not occur in Mozilla 1.6 and earlier. This is a new bug for
Mozilla 1.7.

Reproducible: Always
Steps to Reproduce:
1.Run testcase
2.Note the errors in the testcase (its well documented)
3.

Actual Results:  
Got incorrect serialization results.

Expected Results:  
Correctly serialized the input.

Check the testcase. There's 4 separate testcases. The first 2 work, the last 2
don't. Note again that this is a Mozilla 1.7 issue.

Comment 1

[William J. Edney]

Attachment: A test of the XMLSerializer breaking namespaces under Moz 1.7

Comment 2

[Peter Van der Beken [:peterv]]

Jonas: shouldn't the GetNodeInfo call in nsGenericHTMLElement::SetAttrAndNotify
(http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsGenericHTMLElement.cpp#1664)
use aPrefix?

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 151528 [details] [diff] [review]
v1

This seems like the right thing and it fixes the bug. I can't think of anything
that this could be breaking, you?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 151528 [details] [diff] [review]
v1

I think there is some other bug filed on this issue, or at least it was talked
about in some other bug.
The same problem exists in XUL. r=me if you fix it there too.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 151528 [details] [diff] [review]
v1

sr=jst

Comment 7

[Peter Van der Beken [:peterv]]

Note that we probably get the wrong attribute for the mutation events (see
http://bugzilla.mozilla.org/show_bug.cgi?id=232009#c4).

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Patch that was checked in

Comment 9

[Peter Van der Beken [:peterv]]

Comment on attachment 151669 [details] [diff] [review]
Patch that was checked in

Carrying forward r/sr and asking for branch approval: trivial fix so that
attributes in XHTML and XUL elements don't lose their prefix. Low-risk.

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 151669 [details] [diff] [review]
Patch that was checked in

a=mkaply for 1.7.1

Comment 11

[Peter Van der Beken [:peterv]]

Checked in to trunk and 1.7 branch.

Comment 12

[Hiro]

AVIARY_1_0_20040515_BRANCH does not checkin yet.

Comment 13

[Johnny Stenback (:jst)]

Fixed on the aviary branch now too.

Comment 14

[William J. Edney]

I have been remiss in thanking everyone involved, especially Peter, for fixing
this bug so quickly. This was a showstopper for my product under 1.7.

Thanks guys!

Cheers,

- Bill