Closed Bug 248216 Opened 20 years ago Closed 20 years ago

Mismatched new[]/delete in nsTextFrame.cpp

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: pkwarren, Assigned: pkwarren)

Details

Attachments

(1 file)

Patch v1
766 bytes, patch
dbaron
: review+
dbaron
: superreview+
Details | Diff | Splinter Review 
In nsTextFrame.cpp, mTypes is allocated with the C++ array new, but is not freed
with the array delete. Since it is an array of basic types, I don't this this
affects anything, but it should be fixed for consistency.
Attached patch Patch v1 — — Splinter Review 
Assignee: nobody → pkwarren
Status: NEW → ASSIGNED

    
  

        Attachment #151484 -
        Flags: superreview?(dbaron)

        Attachment #151484 -
        Flags: review?(dbaron)

        Attachment #151484 -
        Flags: superreview?(dbaron)

        Attachment #151484 -
        Flags: superreview+

        Attachment #151484 -
        Flags: review?(dbaron)

        Attachment #151484 -
        Flags: review+

    
    

    
  
Fixed.

Checking in nsTextFrame.cpp;
/cvsroot/mozilla/layout/html/base/src/nsTextFrame.cpp,v  <--  nsTextFrame.cpp
new revision: 1.465; previous revision: 1.464
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: