248240 - Can not save message to Drafts folder on IMAP server

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Adam Lent]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040616 Firefox/0.9
Build Identifier: 20040616

Upon clicking "Save" on an IMAP account where the Drafts folder is located on
the IMAP server, the following error is resported, "The current command did not
succeed.  The mail server responded: Invalid argument to APPEND."  This JUST
started on the builds FOLLOWING the .7RC version of 20040614.  It appeared and
continues in all versions from 20040615, including the .7 release.  This occurs
when saving a new message as well as editing and saving an existing message in
the Drafts folder. It does not affect saving to the "Templates" folder or when
copying sent mail to a "Sent Items" folder on the IMAP server.

Reproducible: Always
Steps to Reproduce:
1.Create new mail message using IMAP account
2.Click Save
3.Opening folder is seen followed by error message indicated above

Actual Results:  
Error message reported

Expected Results:  
Mail message saved to Drafts folder.

Comment 1

[Adam Lent]

Checked functionality against Mozilla Mail and Newsgroups module and found that
the 1.7 trunk works properly (even the current nightlies of 1.7).  All
subsequent trunks (1.8a1, etc.) do not work.  Same error reported, upon
attempting to save Draft onto IMAP server Draft folder.

Comment 2

[David :Bienvenu]

Can you attach an imap protocol log of a session where you try to save a draft?
thx...

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Comment 3

[Adam Lent]

(In reply to comment #2)
I have created an IMAP user account for you to test with on the server I
administer.  The user name is "test", the password is "test" and the IMAP server
name is "telemedia.net".  You should be able to reproduce this problem with any
build from 20040615 and newer.  You should also see that any build, prior to
that date, works properly.

Comment 4

[David :Bienvenu]

OK, thx, I can recreate this, and I'm debugging it now. There are two things
going on here - my first save attempt fails silently, and the second one fails
as you describe. I believe the second failure is because we no longer store the
/SEEN flag when we save a draft, so the flag string is null, and I bet the
server you're using fails to parse the command append "Drafts" () {696}...
because we're not passing in any flags. The flag list is optional, so we can
omit it if there are no flags. I believe the server should allow an empty list,
but we can omit the empty list.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

proposed fix.

Comment 6

[David :Bienvenu]

Comment on attachment 152216 [details] [diff] [review]
proposed fix

don't send an empty flag string if flags is 0.

Comment 7

[David :Bienvenu]

fixed on trunk and branch.

Comment 8

[Adam Lent]

(In reply to comment #7)
Confirmed.  Works as expected.