248468 - [FIXr]File immediately saved when choosing directory with keyboard

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Mac Wendelboe]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

When saving something (image, page or whatever) you open the "Save as" dialog by
f.ex. typing CTRL-S. Navigating the directory tree using the keyboard works fine
for going up the tree (SHIFT-TAB to the ".." button and press SPACE), but when
going down the tree by highligting a directory and pressing ENTER, you are not
faced whith contents of the chosen directory for further browsing. Instead
saving is immediately processed in the chosen directory.

Reproducible: Always
Steps to Reproduce:
1. Choose any item on a webpage, f.ex. an image, right click and choose save as..
2. Use the keyboard to select a directory: SHIFT-TAB to the directory listing
and move the selector using the arrow keys.
3. Enter the selected directory by pressing ENTER (SPACE doesn't have any
functionality here, and the "Save" button reads "Open").
Actual Results:  
The directory is entered and the image is immediately saved.

Expected Results:  
You should have been given the possibility to navigate deeper into the directory
tree.

Comment 1

[Mac Wendelboe]

There is an easy workaround: Pressing SHIFT-ENTER instead of ENTER. But I
believe this is not intentional. I believe the functionality of ENTER versus
SHIFT-ENTER in this context should be switched.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 152980 [details] [diff] [review]
Patch

So the problem here was that the onkeypress handler went to the selected dir,
after which no dir was selected so the "ok" button reverted to being a "save"
button.  Then ondialogaccept fired, since the event's bubbling was not
prevented and we saved.

Just removing the code in the keypress handler works, since now when
ondialogaccept fires a directory is selected, so the "ok" button is an "open"
button, not a "save" button.  Then ondialogaccept just deals.

Comment 4

[Boris Zbarsky [:bzbarsky]]

mconnor, would you review the firefox part of this?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 152980 [details] [diff] [review]
Patch

jag, could you sr?

Comment 6

[jag (Peter Annema)]

Comment on attachment 152980 [details] [diff] [review]
Patch

sr=jag

Comment 7

[Boris Zbarsky [:bzbarsky]]

Taking for checkin once the tree reopens.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 152980 [details] [diff] [review]
Patch

r=[e-mail] for the toolkit changes.  I can also land this on
aviary since I imagine you don't have an aviary tree.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.8a3 or 1.8b or whatever this next milestone is.

mconnor, if you'd do the aviary branch honors?  You're right that I don't have
an aviary tree.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 152980 [details] [diff] [review]
Patch

I think this is worth taking on the 1.7 branch.  Very low risk fix.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Checked in on 1.7 branch.