Closed Bug 248578 Opened 20 years ago Closed 20 years ago

Classic theme, textcolor wrong when click on disabled button

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(2 files, 1 obsolete file)

patch
990 bytes, patch
Details | Diff | Splinter Review
patch not ifdef gtk2
1.09 KB, patch
bryner
: review+
roc
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040624
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040624

Classic theme, GTK2 build, when click on disabled button, button text turned to
black from gray.

Reproducible: Always
Steps to Reproduce:
1.Menu->Edit->Preferences
2.Click on disabled button, e.g. "Use Current Group", "Restore Default"


Actual Results:  
Button text color turned to Black

Expected Results:  
Button text color keep gray
Attached patch patch (obsolete) — — Splinter Review 
just change :hover:active to buttondown="true"
Assignee: themes → ginn.chen
Status: NEW → ASSIGNED
Attachment #151659 - Flags: superreview?(bryner)
Attachment #151659 - Flags: review?(robin.lu)
Attached patch patch — — Splinter Review 
last patch not good, try this one
Attachment #151659 - Attachment is obsolete: true
Attachment #151659 - Flags: superreview?(bryner)
Attachment #151659 - Flags: review?(robin.lu)
Attachment #151676 - Flags: superreview?(bryner)
Attachment #151676 - Flags: review?(robin.lu)
Comment on attachment 151676 [details] [diff] [review]
patch

Do I need #ifdef here?
if do not need ifdef, please r/sr this one, thanks
Attachment #151676 - Flags: superreview?(bryner)
Attachment #151676 - Flags: review?(robin.lu)
Comment on attachment 151679 [details] [diff] [review]
patch not ifdef gtk2

This bug is obviously, and only add 1 line can solve it.
Attachment #151679 - Flags: superreview?(roc)
Attachment #151679 - Flags: review?(bryner)
Attachment #151679 - Flags: superreview?(roc) → superreview+
Attachment #151679 - Flags: review?(bryner) → review+
fixed!
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
What was wrong with putting !important on the color: GrayText; line?
Add !important after GrayText couldn't fix this.
Well it worked for mvl when he tried it for me using an old build...
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: