248603 - BeOS nsLookAndFeel.cpp has incorrect return value for a selector that doesn't exist

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Simon]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7b) Gecko/20040326 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7b) Gecko/20040326 Firefox/0.8.0+

nsLookAndFeel::GetMetric should return 0 when asked for a selector that doesn't
exist. This was changed in the windows port on 2000-11-29 with the comment
"..made all platforms return 0 for a selector that doesn't exist..." -
unfortunately BeOS's nsLookAndFeel wasn't included in the change, and still
returns -1.

This problem has recently shown up with the change that a high contrast theme is
used on windows if the user has selected a global high-contrast theme. As
nsLookAndFeel.cpp in the BeOS port does not return 0 when asked about this,
mozilla always uses the high contrast theme on BeOS.

Simple 1-line patch on the way...

Reproducible: Always
Steps to Reproduce:

Comment 1

[Simon]

Attachment: patch (diff -up8) - return 0 by default like other platforms

Simple 1 line change to match other platforms, and fix problems mentioned in
http://bugzilla.mozilla.org/show_bug.cgi?id=246213

Comment 2

[Simon]

Comment on attachment 151677 [details] [diff] [review]
patch (diff -up8) - return 0 by default like other platforms

Review reques for very simple patch

Comment 3

[Sergei Dolgov]

Comment on attachment 151677 [details] [diff] [review]
patch (diff -up8) - return 0 by default like other platforms

r=[e-mail]

Comment 4

[Sergei Dolgov]

Fixed
2004-07-14 15:39
"bug 248603. Fix for high-contrast themes. r=[e-mail]. BeOS-port only"

Comment 5

[Niels Reedijk]

Checkin on AVIARY by db48x%yahoo.com 
 
"Check in several BeOS bugs that are already checked in on the trunk. All are 
r=twh ([e-mail]) except the last which is r=Sergei Dolgov 
([e-mail]). a=carte blanche ([03:53:40] 
<nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for 
any change that involves the beos-only code)"