248694 - nsIParser::GetCommand is a wide string for no reason

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

all places would, really, prefer an nsACString&

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

oops, this misses a change to nsParser.h, to change the prototype to nsCString&
too... but I'm not going to attach a new patch for that unless requested

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 151725 [details] [diff] [review]
patch

>Index: parser/htmlparser/src/nsParser.cpp
>@@ -449,13 +449,13 @@ NS_IMETHODIMP_(void) nsParser::SetComman
>   nsCAutoString theCommand(aCommand);
>   if(theCommand.Equals(kViewSourceCommand))
>     mCommand=eViewSource;
>   else if(theCommand.Equals(kViewFragmentCommand))
>     mCommand=eViewFragment;
>   else mCommand=eViewNormal;
>-  mCommandStr.AssignWithConversion(aCommand);
>+  mCommandStr.Assign(aCommand);

Why not set mCommandStr up front and the eliminate theCommand (and just call
equals on mCommandStr in that if cascade)?

r+sr=bzbarsky with that change.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: merged to trunk, comment addressed

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in parser/htmlparser/public/nsIParser.h;
/cvsroot/mozilla/parser/htmlparser/public/nsIParser.h,v  <--  nsIParser.h
new revision: 1.26; previous revision: 1.25
done
Checking in parser/htmlparser/src/nsParser.cpp;
/cvsroot/mozilla/parser/htmlparser/src/nsParser.cpp,v  <--  nsParser.cpp
new revision: 3.345; previous revision: 3.344
done
Checking in parser/htmlparser/src/nsParser.h;
/cvsroot/mozilla/parser/htmlparser/src/nsParser.h,v  <--  nsParser.h
new revision: 3.128; previous revision: 3.127
done
Checking in content/xml/document/src/nsXMLContentSink.cpp;
/cvsroot/mozilla/content/xml/document/src/nsXMLContentSink.cpp,v  <-- 
nsXMLContentSink.cpp
new revision: 1.328; previous revision: 1.327
done