Closed
Bug 248695
Opened 22 years ago
Closed 22 years ago
string code misuses realloc
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
timeless
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
timeless points out that we should take care in how we call realloc:
http://bugzilla.mozilla.org/show_bug.cgi?id=244478#c13
i noticed that the new string code calls realloc, but does so in a manner that
could lead to memory leaks. we should fix that.
|
Assignee | |
Updated•22 years ago
|
Target Milestone: --- → mozilla1.8alpha2
|
|
Assignee | |
Comment 1•22 years ago
|
||
Simple patch.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #152034 -
Flags: review?(timeless)
|
|
Assignee | |
Updated•22 years ago
|
Attachment #152034 -
Flags: superreview?(dbaron)
Attachment #152034 -
Flags: superreview?(dbaron) → superreview+
Attachment #152034 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Updated•22 years ago
|
Target Milestone: mozilla1.8alpha2 → mozilla1.8beta
|
|
Assignee | |
Comment 2•22 years ago
|
||
fixed-on-trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•