248966 - In <EdAECSSAttributes.js>, 2 "Warning: assignment to undeclared variable" (i & value)

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040616] (release) (W98SE)
and
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a1) Gecko/20040520] (release) (W98SE)

{{
Warning: assignment to undeclared variable i
Source File: chrome://editor/content/EdAECSSAttributes.js
Line: 66

Warning: assignment to undeclared variable value
Source File: chrome://editor/content/EdAECSSAttributes.js
Line: 69
}}

My case is when opening 'Advaned Properties' for a |<DIV>|...

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <EdAECSSAttributes.js> [Checked in: Comment 7]

Fixes the 2 reported warnings,
plus another one that should be (!),
plus removes an unused var.

Comment 2

[Serge Gautherie (:sgautherie)]

Brendan:
Shouldn't we get another warning for |name| at line 68 too ??

Comment 3

[Brendan Eich [:brendan]]

Note that window.name is a DOM level 0 property, and var does not override a
pre-existing property of the same name, so lack of var leaves name in a document
script referring to window.name.

/be

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Note that window.name is a DOM level 0 property, and var does not override a
> pre-existing property of the same name, so lack of var leaves name in a document
> script referring to window.name.

Ah ! Then, it's correct not to get the warning on |name| :-)
Yet, adding |var| on it is what we want here, isn't it !?

Comment 5

[Brendan Eich [:brendan]]

Adding var won't override the window property.  If you don't want to change the
name of the window (used by target= and window.open's second argument to find
the named window), then it would be better to use a different variable name --
and of course to declare it with var.

/be

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 151908 [details] [diff] [review]
(Av1) <EdAECSSAttributes.js>
[Checked in: Comment 7]

r=[e-mail]

Serge, add yourself on a new contributor line :-)

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Checked in, on Serge's request.