249028 - Make XPCOM_DEBUG_BREAK=trap work on OS X

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Peter Van der Beken [:peterv]]

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Support XPCOM_DEBUG_BREAK=trap

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 151939 [details] [diff] [review]
Support XPCOM_DEBUG_BREAK=trap

looks fine to me.

peterv, can you check this in?

Comment 3

[Kevin Gerich]

I'm trying to do a GTK build on Mac OS X, and I get this error:

make[4]: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla/xpcom/glue'
make[4]: Entering directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla/xpcom/base'
nsDebugImpl.cpp
c++ -o nsDebugImpl.o -c -DOSTYPE=\"Darwin7.4.0\" -DOSARCH=\"Darwin\"
-D_IMPL_NS_COM  -I../../dist/include/string -I../../dist/include/xpcom
-I../../dist/include
-I/Users/kev/MozillaSource/gtkfftrunk/mozilla/dist/include/nspr    
-I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions
-Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -fpascal-strings
-no-cpp-precomp -fno-common -fshort-wchar -pipe  -DNDEBUG -DTRIMMED -O 
-I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../mozilla-config.h
-Wp,-MD,.deps/nsDebugImpl.pp nsDebugImpl.cpp
nsDebugImpl.cpp:69:24: MacTypes.h: No such file or directory
nsDebugImpl.cpp: In member function `virtual nsresult nsDebugImpl::Break(const 
   char*, int)':
nsDebugImpl.cpp:352: error: `Debugger' undeclared (first use this function)
nsDebugImpl.cpp:352: error: (Each undeclared identifier is reported only once 
   for each function it appears in.)
make[4]: *** [nsDebugImpl.o] Error 1
make[4]: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla/xpcom/base'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla/xpcom'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla'
make: *** [alldep] Error 2
make: Leaving directory `/Users/kev/MozillaSource/gtkfftrunk/mozilla'


If I take out the three lines added by the patch, the build completes

Comment 4

[Kevin Gerich]

Should I file a separate bug?

Comment 7

[timeless]

Attachment: don't require MacTypes.h

Comment 8

[cls]

Attachment: Use Debugger if TARGET_CARBON is set

Debugger() comes from CoreServices which we'll only link against when building
against the carbon or cocoa toolkits.

Comment 9

[cls]

Patch has been checked in.

Comment 10

[cls]

*** Bug 257773 has been marked as a duplicate of this bug. ***